Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2697)

Unified Diff: tools/perf/benchmarks/thread_times.py

Issue 816353008: [Telemetry] Explicitly define Name() method for all perf benchmarks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/benchmarks/thread_times.py
diff --git a/tools/perf/benchmarks/thread_times.py b/tools/perf/benchmarks/thread_times.py
index 46b0d91b6833cd42581f6d8bdfd116826f52144d..c8b01fdd3df3e6e4940dbb6220606de38daefb2e 100644
--- a/tools/perf/benchmarks/thread_times.py
+++ b/tools/perf/benchmarks/thread_times.py
@@ -13,6 +13,10 @@ class _ThreadTimes(benchmark.Benchmark):
parser.add_option('--report-silk-details', action='store_true',
help='Report details relevant to silk.')
+ @classmethod
+ def Name(cls):
+ return 'thread_times'
+
def CreatePageTest(self, options):
return thread_times.ThreadTimes(options.report_silk_details)
@@ -23,19 +27,19 @@ class ThreadTimesKeySilkCases(_ThreadTimes):
cases."""
page_set = page_sets.KeySilkCasesPageSet
+ @classmethod
+ def Name(cls):
+ return 'thread_times.key_silk_cases'
+
@benchmark.Enabled('android', 'linux')
class ThreadTimesKeyHitTestCases(_ThreadTimes):
"""Measure timeline metrics while performing smoothness action on key hit
testing cases."""
page_set = page_sets.KeyHitTestCasesPageSet
-@benchmark.Disabled
-class LegacySilkBenchmark(ThreadTimesKeySilkCases):
- """Same as thread_times.key_silk_cases but with the old name."""
@classmethod
def Name(cls):
- return "silk.key_silk_cases"
-
+ return 'thread_times.key_hit_test_cases'
@benchmark.Enabled('android')
class ThreadTimesFastPathMobileSites(_ThreadTimes):
@@ -45,6 +49,10 @@ class ThreadTimesFastPathMobileSites(_ThreadTimes):
page_set = page_sets.KeyMobileSitesSmoothPageSet
options = {'page_label_filter' : 'fastpath'}
+ @classmethod
+ def Name(cls):
+ return 'thread_times.key_mobile_sites_smooth'
+
@benchmark.Enabled('android')
class ThreadTimesSimpleMobileSites(_ThreadTimes):
@@ -52,6 +60,10 @@ class ThreadTimesSimpleMobileSites(_ThreadTimes):
http://www.chromium.org/developers/design-documents/rendering-benchmarks"""
page_set = page_sets.SimpleMobileSitesPageSet
+ @classmethod
+ def Name(cls):
+ return 'thread_times.simple_mobile_sites'
+
@benchmark.Disabled('win') # crbug.com/443781
class ThreadTimesCompositorCases(_ThreadTimes):
@@ -63,8 +75,16 @@ class ThreadTimesCompositorCases(_ThreadTimes):
def CustomizeBrowserOptions(self, options):
silk_flags.CustomizeBrowserOptionsForSoftwareRasterization(options)
+ @classmethod
+ def Name(cls):
+ return 'thread_times.tough_compositor_cases'
+
@benchmark.Enabled('android')
class ThreadTimesPolymer(_ThreadTimes):
"""Measures timeline metrics while performing smoothness action on
Polymer cases."""
page_set = page_sets.PolymerPageSet
+ @classmethod
+ def Name(cls):
+ return 'thread_times.polymer'
+

Powered by Google App Engine
This is Rietveld 408576698