Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Unified Diff: tools/perf/benchmarks/start_with_url.py

Issue 816353008: [Telemetry] Explicitly define Name() method for all perf benchmarks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/benchmarks/start_with_url.py
diff --git a/tools/perf/benchmarks/start_with_url.py b/tools/perf/benchmarks/start_with_url.py
index 895dd9116c37f4ee3bea907fe4a9820ca628cd8c..b331bc9f1f2ba29bcd703798bfc72694c430a54d 100644
--- a/tools/perf/benchmarks/start_with_url.py
+++ b/tools/perf/benchmarks/start_with_url.py
@@ -11,6 +11,10 @@ class _StartWithUrl(benchmark.Benchmark):
page_set = page_sets.StartupPagesPageSet
test = startup.StartWithUrl
+ @classmethod
+ def Name(cls):
+ return 'start_with_url.startup_pages'
+
def CreatePageTest(self, options):
is_cold = (self.tag == 'cold')
return self.test(cold=is_cold)
@@ -23,6 +27,10 @@ class StartWithUrlCold(_StartWithUrl):
tag = 'cold'
options = {'pageset_repeat': 5}
+ @classmethod
+ def Name(cls):
+ return 'start_with_url.cold.startup_pages'
+
@benchmark.Enabled('has tabs')
@benchmark.Disabled('chromeos', 'linux', 'mac', 'win')
@@ -30,3 +38,7 @@ class StartWithUrlWarm(_StartWithUrl):
"""Measure time to start Chrome warm with startup URLs"""
tag = 'warm'
options = {'pageset_repeat': 10}
+ @classmethod
+ def Name(cls):
+ return 'start_with_url.warm.startup_pages'
+

Powered by Google App Engine
This is Rietveld 408576698