Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Unified Diff: tools/perf/benchmarks/tab_switching.py

Issue 816353008: [Telemetry] Explicitly define Name() method for all perf benchmarks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/benchmarks/tab_switching.py
diff --git a/tools/perf/benchmarks/tab_switching.py b/tools/perf/benchmarks/tab_switching.py
index dd82970949d4be8b33922c8c4aaf3d0208ffdc25..55fd603106540b009f20de0ea756a82290d876d1 100644
--- a/tools/perf/benchmarks/tab_switching.py
+++ b/tools/perf/benchmarks/tab_switching.py
@@ -20,6 +20,10 @@ class TabSwitchingTop10(benchmark.Benchmark):
test = tab_switching.TabSwitching
page_set = page_sets.Top10PageSet
+ @classmethod
+ def Name(cls):
+ return 'tab_switching.top_10'
+
@benchmark.Enabled('has tabs')
class TabSwitchingTypical25(benchmark.Benchmark):
@@ -33,6 +37,10 @@ class TabSwitchingTypical25(benchmark.Benchmark):
test = tab_switching.TabSwitching
page_set = page_sets.Typical25PageSet
+ @classmethod
+ def Name(cls):
+ return 'tab_switching.typical_25'
+
@benchmark.Enabled('has tabs')
class TabSwitchingFiveBlankTabs(benchmark.Benchmark):
@@ -47,6 +55,10 @@ class TabSwitchingFiveBlankTabs(benchmark.Benchmark):
page_set = page_sets.FiveBlankPagesPageSet
options = {'pageset_repeat': 10}
+ @classmethod
+ def Name(cls):
+ return 'tab_switching.five_blank_pages'
+
@benchmark.Enabled('has tabs')
class TabSwitchingToughEnergyCases(benchmark.Benchmark):
@@ -61,9 +73,17 @@ class TabSwitchingToughEnergyCases(benchmark.Benchmark):
page_set = page_sets.ToughEnergyCasesPageSet
options = {'pageset_repeat': 10}
+ @classmethod
+ def Name(cls):
+ return 'tab_switching.tough_energy_cases'
+
@benchmark.Disabled # Just for local testing, not on waterfall.
class TabSwitchingFlashEnergyCases(benchmark.Benchmark):
test = tab_switching.TabSwitching
page_set = page_sets.FlashEnergyCasesPageSet
options = {'pageset_repeat': 10}
+ @classmethod
+ def Name(cls):
+ return 'tab_switching.flash_energy_cases'
+

Powered by Google App Engine
This is Rietveld 408576698