Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: tools/perf/benchmarks/media.py

Issue 816353008: [Telemetry] Explicitly define Name() method for all perf benchmarks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/benchmarks/media.py
diff --git a/tools/perf/benchmarks/media.py b/tools/perf/benchmarks/media.py
index a45fd5d5bc90e4f8ac2772d26f4a38664ef95da0..47fed0bd15cccf7ca63a0425cb25bf597af8cc66 100644
--- a/tools/perf/benchmarks/media.py
+++ b/tools/perf/benchmarks/media.py
@@ -39,6 +39,10 @@ class Media(benchmark.Benchmark):
test = media.Media
page_set = page_sets.ToughVideoCasesPageSet
+ @classmethod
+ def Name(cls):
+ return 'media.tough_video_cases'
+
@benchmark.Disabled
class MediaNetworkSimulation(benchmark.Benchmark):
@@ -46,6 +50,10 @@ class MediaNetworkSimulation(benchmark.Benchmark):
test = media.Media
page_set = page_sets.MediaCnsCasesPageSet
+ @classmethod
+ def Name(cls):
+ return 'media.media_cns_cases'
+
@benchmark.Enabled('android')
@benchmark.Disabled('l', 'android-webview') # WebView: crbug.com/419689
@@ -57,6 +65,10 @@ class MediaAndroid(benchmark.Benchmark):
# Exclude is_4k and 50 fps media files (garden* & crowd*).
options = {'page_label_filter_exclude': 'is_4k,is_50fps'}
+ @classmethod
+ def Name(cls):
+ return 'media.android.tough_video_cases'
+
@benchmark.Enabled('chromeos')
class MediaChromeOS4kOnly(benchmark.Benchmark):
@@ -71,6 +83,10 @@ class MediaChromeOS4kOnly(benchmark.Benchmark):
'page_label_filter_exclude': 'is_50fps'
}
+ @classmethod
+ def Name(cls):
+ return 'media.chromeOS4kOnly.tough_video_cases'
+
@benchmark.Enabled('chromeos')
class MediaChromeOS(benchmark.Benchmark):
@@ -85,6 +101,10 @@ class MediaChromeOS(benchmark.Benchmark):
# Exclude is_50fps test files: crbug/331816
options = {'page_label_filter_exclude': 'is_4k,is_50fps'}
+ @classmethod
+ def Name(cls):
+ return 'media.chromeOS.tough_video_cases'
+
@benchmark.Disabled('android-webview') # crbug.com/419689
class MediaSourceExtensions(benchmark.Benchmark):
@@ -92,6 +112,10 @@ class MediaSourceExtensions(benchmark.Benchmark):
test = _MSEMeasurement
page_set = page_sets.MseCasesPageSet
+ @classmethod
+ def Name(cls):
+ return 'media.mse_cases'
+
def CustomizeBrowserOptions(self, options):
# Needed to allow XHR requests to return stream objects.
options.AppendExtraBrowserArgs(

Powered by Google App Engine
This is Rietveld 408576698