Use new phantom handles for ScriptWrappable.

Use new phantom handles for ScriptWrappable.

This cannot commit before https://codereview.chromium.org/753553002 has rolled.

R=hpayer@chromium.org, jochen@chromium.org
BUG=

[jochen (gone - plz use gerrit), 2014-12-15 15:37:36]

lgtm

[haraken, 2014-12-15 15:49:37]

haraken@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2014-12-15 15:49:37]

LGTM. This is a nice change.

https://codereview.chromium.org/806693004/diff/1/Source/bindings/core/v8/Scri...
File Source/bindings/core/v8/ScriptWrappable.h (right):

https://codereview.chromium.org/806693004/diff/1/Source/bindings/core/v8/Scri...
Source/bindings/core/v8/ScriptWrappable.h:162: static void setWeakCallback(const
v8::InternalFieldsCallbackData<WrapperTypeInfo, ScriptWrappable>& data)

setWeakCallback => wealCallback?

It is not setting a weak callback, but this is a weak callback.

https://codereview.chromium.org/806693004/diff/1/Source/bindings/core/v8/Scri...
Source/bindings/core/v8/ScriptWrappable.h:169:
scriptWrappable->m_wrapper.Empty();

Shall we rename Empty to Reset or Clear, for consistency with other V8 APIs to
clear val_?

[Hannes Payer (out of office), 2014-12-15 15:54:50]

lgtm

[Erik Corry Chromium.org, 2015-01-07 15:46:25]

I updated it with more uses.  Also added a flag to some traits, that I intend to
use in the next V8 change.

[haraken, 2015-01-07 15:51:42]

Still LGTM.

https://codereview.chromium.org/806693004/diff/20001/Source/bindings/core/v8/...
File Source/bindings/core/v8/ScriptWrappable.h (right):

https://codereview.chromium.org/806693004/diff/20001/Source/bindings/core/v8/...
Source/bindings/core/v8/ScriptWrappable.h:169:
scriptWrappable->m_wrapper.Empty();

Do we go with Empty, whereas other similar V8 APIs are named Clear or Reset?

[Erik Corry Chromium.org, 2015-01-07 16:07:57]

https://codereview.chromium.org/806693004/diff/20001/Source/bindings/core/v8/...
File Source/bindings/core/v8/DOMWrapperMap.h (right):

https://codereview.chromium.org/806693004/diff/20001/Source/bindings/core/v8/...
Source/bindings/core/v8/DOMWrapperMap.h:95: static const bool kUseSetWeak =
true;
This is in preparation for planned changes in V8.

https://codereview.chromium.org/806693004/diff/20001/Source/bindings/core/v8/...
File Source/bindings/core/v8/ScriptWrappable.h (right):

https://codereview.chromium.org/806693004/diff/20001/Source/bindings/core/v8/...
Source/bindings/core/v8/ScriptWrappable.h:169:
scriptWrappable->m_wrapper.Empty();
On 2015/01/07 15:51:41, haraken wrote:
> 
> Do we go with Empty, whereas other similar V8 APIs are named Clear or Reset?

Empty is to match the preexisting IsEmpty().  Reset is different in that it
tears down the weak handle, which isn't what we want here, since it is already
in the process of being torn down.

[Erik Corry Chromium.org, 2015-01-07 16:19:15]

I'm putting this on hold to make some changes to the V8 API that Dan suggested.

[sof, 2015-03-09 10:59:20]

On 2015/01/07 16:19:15, Erik Corry Chromium.org wrote:
> I'm putting this on hold to make some changes to the V8 API that Dan
suggested.

Had time since then to take those suggestions into account? (sorry, just keen :)
)

[jochen (gone - plz use gerrit), 2015-03-09 16:16:41]

yes, but now we're changing the API on the V8 side.... really soon now!