Chromium Code Reviews

Side by Side Diff: Source/bindings/core/v8/V8ValueCache.h

Issue 806693004: Use new phantom handles for ScriptWrappable. Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Start using V8 phantom handles in Blink Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff |
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 28 matching lines...)
39 public: 39 public:
40 // Weak traits: 40 // Weak traits:
41 typedef StringImpl WeakCallbackDataType; 41 typedef StringImpl WeakCallbackDataType;
42 typedef v8::PersistentValueMap<StringImpl*, v8::String, StringCacheMapTraits > MapType; 42 typedef v8::PersistentValueMap<StringImpl*, v8::String, StringCacheMapTraits > MapType;
43 43
44 static WeakCallbackDataType* WeakCallbackParameter( 44 static WeakCallbackDataType* WeakCallbackParameter(
45 MapType* map, StringImpl* key, v8::Local<v8::String>& value) { return ke y; } 45 MapType* map, StringImpl* key, v8::Local<v8::String>& value) { return ke y; }
46 static void DisposeCallbackData(WeakCallbackDataType* callbackData) { } 46 static void DisposeCallbackData(WeakCallbackDataType* callbackData) { }
47 47
48 static MapType* MapFromWeakCallbackData( 48 static MapType* MapFromWeakCallbackData(
49 const v8::WeakCallbackData<v8::String, WeakCallbackDataType>&); 49 const v8::PhantomCallbackData<WeakCallbackDataType>&);
50 50
51 static StringImpl* KeyFromWeakCallbackData( 51 static StringImpl* KeyFromWeakCallbackData(
52 const v8::WeakCallbackData<v8::String, WeakCallbackDataType>& data) 52 const v8::PhantomCallbackData<WeakCallbackDataType>& data)
53 { 53 {
54 return data.GetParameter(); 54 return data.GetParameter();
55 } 55 }
56 56
57 static void Dispose(v8::Isolate*, v8::UniquePersistent<v8::String> value, St ringImpl* key); 57 static void Dispose(v8::Isolate*, v8::UniquePersistent<v8::String> value, St ringImpl* key);
58 }; 58 };
59 59
60 60
61 class StringCache { 61 class StringCache {
62 public: 62 public:
(...skipping 30 matching lines...)
93 93
94 // Note: RefPtr is a must as we cache by StringImpl* equality, not identity 94 // Note: RefPtr is a must as we cache by StringImpl* equality, not identity
95 // hence lastStringImpl might be not a key of the cache (in sense of identit y) 95 // hence lastStringImpl might be not a key of the cache (in sense of identit y)
96 // and hence it's not refed on addition. 96 // and hence it's not refed on addition.
97 RefPtr<StringImpl> m_lastStringImpl; 97 RefPtr<StringImpl> m_lastStringImpl;
98 }; 98 };
99 99
100 } // namespace blink 100 } // namespace blink
101 101
102 #endif // V8ValueCache_h 102 #endif // V8ValueCache_h
OLDNEW

Powered by Google App Engine