Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Unified Diff: Source/bindings/core/v8/DOMWrapperWorld.cpp

Issue 806693004: Use new phantom handles for ScriptWrappable. Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Start using V8 phantom handles in Blink Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/v8/DOMWrapperWorld.cpp
diff --git a/Source/bindings/core/v8/DOMWrapperWorld.cpp b/Source/bindings/core/v8/DOMWrapperWorld.cpp
index 20de0ae673ea43f269e235aa099c4284745e4a34..d79e03823c25a6c7c66c93fb88d5d335775fae52 100644
--- a/Source/bindings/core/v8/DOMWrapperWorld.cpp
+++ b/Source/bindings/core/v8/DOMWrapperWorld.cpp
@@ -225,7 +225,7 @@ void DOMWrapperWorld::registerDOMObjectHolderInternal(PassOwnPtr<DOMObjectHolder
{
ASSERT(!m_domObjectHolders.contains(holderBase.get()));
holderBase->setWorld(this);
- holderBase->setWeak(&DOMWrapperWorld::weakCallbackForDOMObjectHolder);
+ holderBase->setPhantom(&DOMWrapperWorld::phantomCallbackForDOMObjectHolder);
m_domObjectHolders.add(holderBase);
}
@@ -235,7 +235,7 @@ void DOMWrapperWorld::unregisterDOMObjectHolder(DOMObjectHolderBase* holderBase)
m_domObjectHolders.remove(holderBase);
}
-void DOMWrapperWorld::weakCallbackForDOMObjectHolder(const v8::WeakCallbackData<v8::Value, DOMObjectHolderBase>& data)
+void DOMWrapperWorld::phantomCallbackForDOMObjectHolder(const v8::PhantomCallbackData<DOMObjectHolderBase>& data)
{
DOMObjectHolderBase* holderBase = data.GetParameter();
holderBase->world()->unregisterDOMObjectHolder(holderBase);

Powered by Google App Engine
This is Rietveld 408576698