Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: Source/bindings/core/v8/DOMWrapperWorld.cpp

Issue 806693004: Use new phantom handles for ScriptWrappable. Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Start using V8 phantom handles in Blink Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 207 matching lines...) Expand 10 before | Expand all | Expand 10 after
218 if (!policy.isEmpty()) 218 if (!policy.isEmpty())
219 isolatedWorldContentSecurityPolicies().set(worldId, true); 219 isolatedWorldContentSecurityPolicies().set(worldId, true);
220 else 220 else
221 isolatedWorldContentSecurityPolicies().remove(worldId); 221 isolatedWorldContentSecurityPolicies().remove(worldId);
222 } 222 }
223 223
224 void DOMWrapperWorld::registerDOMObjectHolderInternal(PassOwnPtr<DOMObjectHolder Base> holderBase) 224 void DOMWrapperWorld::registerDOMObjectHolderInternal(PassOwnPtr<DOMObjectHolder Base> holderBase)
225 { 225 {
226 ASSERT(!m_domObjectHolders.contains(holderBase.get())); 226 ASSERT(!m_domObjectHolders.contains(holderBase.get()));
227 holderBase->setWorld(this); 227 holderBase->setWorld(this);
228 holderBase->setWeak(&DOMWrapperWorld::weakCallbackForDOMObjectHolder); 228 holderBase->setPhantom(&DOMWrapperWorld::phantomCallbackForDOMObjectHolder);
229 m_domObjectHolders.add(holderBase); 229 m_domObjectHolders.add(holderBase);
230 } 230 }
231 231
232 void DOMWrapperWorld::unregisterDOMObjectHolder(DOMObjectHolderBase* holderBase) 232 void DOMWrapperWorld::unregisterDOMObjectHolder(DOMObjectHolderBase* holderBase)
233 { 233 {
234 ASSERT(m_domObjectHolders.contains(holderBase)); 234 ASSERT(m_domObjectHolders.contains(holderBase));
235 m_domObjectHolders.remove(holderBase); 235 m_domObjectHolders.remove(holderBase);
236 } 236 }
237 237
238 void DOMWrapperWorld::weakCallbackForDOMObjectHolder(const v8::WeakCallbackData< v8::Value, DOMObjectHolderBase>& data) 238 void DOMWrapperWorld::phantomCallbackForDOMObjectHolder(const v8::PhantomCallbac kData<DOMObjectHolderBase>& data)
239 { 239 {
240 DOMObjectHolderBase* holderBase = data.GetParameter(); 240 DOMObjectHolderBase* holderBase = data.GetParameter();
241 holderBase->world()->unregisterDOMObjectHolder(holderBase); 241 holderBase->world()->unregisterDOMObjectHolder(holderBase);
242 } 242 }
243 243
244 } // namespace blink 244 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698