Source/bindings/core/v8/DOMWrapperMap.h - Issue 806693004: Use new phantom handles for ScriptWrappable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/DOMWrapperMap.h

Issue 806693004: Use new phantom handles for ScriptWrappable. Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Start using V8 phantom handles in Blink Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/core/v8/DOMWrapperMap.h

diff --git a/Source/bindings/core/v8/DOMWrapperMap.h b/Source/bindings/core/v8/DOMWrapperMap.h

index 1981647be7e9e951aeb3e737d5b2fe5072bf8278..f38b4f21b60a6875a881c40e2f3ed0eaff392c80 100644

--- a/Source/bindings/core/v8/DOMWrapperMap.h

+++ b/Source/bindings/core/v8/DOMWrapperMap.h

@@ -92,6 +92,7 @@ private:

class PersistentValueMapTraits {

public:

// Map traits:

+ static const bool kUseSetWeak = true;

Erik Corry Chromium.org 2015/01/07 16:07:56 This is in preparation for planned changes in V8.

typedef HashMap<KeyType*, v8::PersistentContainerValue> Impl;

typedef typename Impl::iterator Iterator;

static size_t Size(const Impl* impl) { return impl->size(); }