Source/bindings/core/v8/V8ValueCache.h - Issue 806693004: Use new phantom handles for ScriptWrappable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/V8ValueCache.h

Issue 806693004: Use new phantom handles for ScriptWrappable. Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Start using V8 phantom handles in Blink Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/core/v8/V8ValueCache.h

diff --git a/Source/bindings/core/v8/V8ValueCache.h b/Source/bindings/core/v8/V8ValueCache.h

index ec7816d519c4c42e469d2370da64653e9851d555..611f134a48e055f4074606599597c9ac9b316766 100644

--- a/Source/bindings/core/v8/V8ValueCache.h

+++ b/Source/bindings/core/v8/V8ValueCache.h

@@ -46,10 +46,10 @@ public:

static void DisposeCallbackData(WeakCallbackDataType* callbackData) { }

static MapType* MapFromWeakCallbackData(

- const v8::WeakCallbackData<v8::String, WeakCallbackDataType>&);

+ const v8::PhantomCallbackData<WeakCallbackDataType>&);

static StringImpl* KeyFromWeakCallbackData(

- const v8::WeakCallbackData<v8::String, WeakCallbackDataType>& data)

+ const v8::PhantomCallbackData<WeakCallbackDataType>& data)

{

return data.GetParameter();

}