Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Unified Diff: Source/bindings/core/v8/V8NPObject.cpp

Issue 806693004: Use new phantom handles for ScriptWrappable. Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Start using V8 phantom handles in Blink Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/v8/V8NPObject.cpp
diff --git a/Source/bindings/core/v8/V8NPObject.cpp b/Source/bindings/core/v8/V8NPObject.cpp
index d8f2e8dcb01b472f03ad597ac05cb2e18617cf0e..9b8de1d72671ef13529eefc91b444e06b2601b9a 100644
--- a/Source/bindings/core/v8/V8NPObject.cpp
+++ b/Source/bindings/core/v8/V8NPObject.cpp
@@ -180,10 +180,10 @@ public:
static void DisposeCallbackData(WeakCallbackDataType* callbackData) { }
static MapType* MapFromWeakCallbackData(
- const v8::WeakCallbackData<v8::FunctionTemplate, WeakCallbackDataType>&);
+ const v8::PhantomCallbackData<WeakCallbackDataType>&);
static PrivateIdentifier* KeyFromWeakCallbackData(
- const v8::WeakCallbackData<v8::FunctionTemplate, WeakCallbackDataType>& data)
+ const v8::PhantomCallbackData<WeakCallbackDataType>& data)
{
return data.GetParameter();
}
@@ -227,7 +227,7 @@ private:
MapType m_map;
};
-V8TemplateMapTraits::MapType* V8TemplateMapTraits::MapFromWeakCallbackData(const v8::WeakCallbackData<v8::FunctionTemplate, WeakCallbackDataType>& data)
+V8TemplateMapTraits::MapType* V8TemplateMapTraits::MapFromWeakCallbackData(const v8::PhantomCallbackData<WeakCallbackDataType>& data)
{
return &V8NPTemplateMap::sharedInstance(data.GetIsolate()).m_map;
}

Powered by Google App Engine
This is Rietveld 408576698