Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 794683005: replace COMPILE_ASSERT with static_assert in components/ (Closed)

Created:
6 years ago by Mostyn Bramley-Moore
Modified:
6 years ago
Reviewers:
Cait (Slow)
CC:
chromium-reviews, tim+watch_chromium.org, vsevik, sadrul, zea+watch_chromium.org, maxbogue+watch_chromium.org, yurys, pvalenzuela+watch_chromium.org, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, kalyank, markusheintz_, aandrey+blink_chromium.org, pfeldman, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

replace COMPILE_ASSERT with static_assert in components/ BUG=442514 Committed: https://crrev.com/470748ce474f8fce7a566eb570021273c88d04c0 Cr-Commit-Position: refs/heads/master@{#309464}

Patch Set 1 #

Patch Set 2 : formatting fixup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -57 lines) Patch
M components/browser_watcher/watcher_metrics_provider_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/captive_portal/captive_portal_types.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M components/content_settings/core/browser/content_settings_default_provider.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M components/content_settings/core/browser/content_settings_policy_provider.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M components/content_settings/core/browser/content_settings_utils.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/content_settings/core/browser/host_content_settings_map.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/crash/app/breakpad_linux.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/crash/browser/crash_handler_host_linux.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h View 1 chunk +3 lines, -2 lines 0 comments Download
M components/devtools_bridge/socket_tunnel_connection.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/devtools_bridge/socket_tunnel_packet_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/history/core/android/android_history_types.cc View 2 chunks +7 lines, -5 lines 0 comments Download
M components/nacl/loader/nacl_ipc_adapter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/nacl/loader/nonsfi/nonsfi_sandbox.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/navigation_metrics/navigation_metrics.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/omnibox/autocomplete_match.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/omnibox/autocomplete_match_type.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/policy/core/common/cloud/cloud_policy_validator.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M components/proximity_auth/wire_message.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sessions/serialized_navigation_entry.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M components/sessions/session_service_commands.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/signin/core/browser/signin_error_controller_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/sync_driver/model_association_manager.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M components/translate/core/browser/translate_browser_metrics.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/translate/core/common/translate_metrics.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/user_manager/user.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/variations/entropy_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/variations/metrics_util.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
Mostyn Bramley-Moore
@Cait: PTAL
6 years ago (2014-12-22 15:07:58 UTC) #2
Cait (Slow)
lgtm
6 years ago (2014-12-22 15:35:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/794683005/1
6 years ago (2014-12-22 19:46:25 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/32015)
6 years ago (2014-12-22 19:53:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/794683005/20001
6 years ago (2014-12-22 20:28:37 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-22 21:15:13 UTC) #10
commit-bot: I haz the power
6 years ago (2014-12-22 21:16:26 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/470748ce474f8fce7a566eb570021273c88d04c0
Cr-Commit-Position: refs/heads/master@{#309464}

Powered by Google App Engine
This is Rietveld 408576698