components/devtools_bridge/socket_tunnel_connection.cc - Issue 794683005: replace COMPILE_ASSERT with static_assert in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/devtools_bridge/socket_tunnel_connection.cc

Issue 794683005: replace COMPILE_ASSERT with static_assert in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: formatting fixup Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h ('k') | components/devtools_bridge/socket_tunnel_packet_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/devtools_bridge/socket_tunnel_connection.cc

diff --git a/components/devtools_bridge/socket_tunnel_connection.cc b/components/devtools_bridge/socket_tunnel_connection.cc

index da9def2614bbb20b10892477a20ef0e55ddadc12..9fba14309f035a0b7086bf42930dd89878d0354d 100644

--- a/components/devtools_bridge/socket_tunnel_connection.cc

+++ b/components/devtools_bridge/socket_tunnel_connection.cc

@@ -30,8 +30,8 @@ void SocketTunnelConnection::Write(scoped_refptr<net::IOBufferWithSize> chunk) {

void SocketTunnelConnection::BuildControlPacket(char* buffer,

int op_code) {

- COMPILE_ASSERT(kControlPacketSizeBytes == 3,

- unexpected_control_packet_size);

+ static_assert(kControlPacketSizeBytes == 3,

+ "kControlPacketSizeBytes should equal 3");

buffer[0] = kControlConnectionId;

buffer[1] = op_code;

buffer[2] = index_ + kMinConnectionId;