components/translate/core/common/translate_metrics.cc - Issue 794683005: replace COMPILE_ASSERT with static_assert in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/translate/core/common/translate_metrics.cc

Issue 794683005: replace COMPILE_ASSERT with static_assert in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: formatting fixup Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/translate/core/common/translate_metrics.cc

diff --git a/components/translate/core/common/translate_metrics.cc b/components/translate/core/common/translate_metrics.cc

index 2c64b5295979c24fc3c25bd105b086db4c8a856a..3f4e10e90c40c25c313db63eeda00e70bace88ef 100644

--- a/components/translate/core/common/translate_metrics.cc

+++ b/components/translate/core/common/translate_metrics.cc

@@ -43,8 +43,8 @@ const MetricsEntry kMetricsEntries[] = {

{UMA_PAGE_SCHEME, kTranslatePageScheme},

{UMA_SIMILAR_LANGUAGE_MATCH, kTranslateSimilarLanguageMatch}, };

-COMPILE_ASSERT(arraysize(kMetricsEntries) == UMA_MAX,

- arraysize_of_kMetricsEntries_should_be_UMA_MAX);

+static_assert(arraysize(kMetricsEntries) == UMA_MAX,

+ "kMetricsEntries should have UMA_MAX elements");

LanguageCheckType GetLanguageCheckMetric(const std::string& provided_code,

const std::string& revised_code) {

« no previous file with comments | « components/translate/core/browser/translate_browser_metrics.cc ('k') | components/user_manager/user.cc » ('j') | no next file with comments »