components/crash/app/breakpad_linux.cc - Issue 794683005: replace COMPILE_ASSERT with static_assert in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/crash/app/breakpad_linux.cc

Issue 794683005: replace COMPILE_ASSERT with static_assert in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: formatting fixup Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/content_settings/core/browser/host_content_settings_map.cc ('k') | components/crash/browser/crash_handler_host_linux.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/crash/app/breakpad_linux.cc

diff --git a/components/crash/app/breakpad_linux.cc b/components/crash/app/breakpad_linux.cc

index 930b7e5900eedc65a5fb9a8851d80adea4350cb5..09a9251e2d80c080617b4ecf70fc7ddb21b887b0 100644

--- a/components/crash/app/breakpad_linux.cc

+++ b/components/crash/app/breakpad_linux.cc

@@ -851,11 +851,11 @@ class NonBrowserCrashHandler : public google_breakpad::CrashGenerationClient {

&serialized_map));

iov[5].iov_base = serialized_map;

#if !defined(ADDRESS_SANITIZER)

- COMPILE_ASSERT(5 == kCrashIovSize - 1, Incorrect_Number_Of_Iovec_Members);

+ static_assert(5 == kCrashIovSize - 1, "kCrashIovSize should equal 6");

#else

iov[6].iov_base = const_cast<char*>(g_asan_report_str);

iov[6].iov_len = kMaxAsanReportSize + 1;

- COMPILE_ASSERT(6 == kCrashIovSize - 1, Incorrect_Number_Of_Iovec_Members);

+ static_assert(6 == kCrashIovSize - 1, "kCrashIovSize should equal 7");

#endif

msg.msg_iov = iov;