components/crash/browser/crash_handler_host_linux.cc - Issue 794683005: replace COMPILE_ASSERT with static_assert in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/crash/browser/crash_handler_host_linux.cc

Issue 794683005: replace COMPILE_ASSERT with static_assert in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: formatting fixup Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/crash/app/breakpad_linux.cc ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/crash/browser/crash_handler_host_linux.cc

diff --git a/components/crash/browser/crash_handler_host_linux.cc b/components/crash/browser/crash_handler_host_linux.cc

index 93ca11eea29f4dcf26ccee8f5a4d80a75e3950f1..7811a048b82b63cdf737cde5ee3bc969454fd946 100644

--- a/components/crash/browser/crash_handler_host_linux.cc

+++ b/components/crash/browser/crash_handler_host_linux.cc

@@ -184,11 +184,11 @@ void CrashHandlerHostLinux::OnFileCanReadWithoutBlocking(int fd) {

iov[5].iov_base = serialized_crash_keys;

iov[5].iov_len = crash_keys_size;

#if !defined(ADDRESS_SANITIZER)

- COMPILE_ASSERT(5 == kCrashIovSize - 1, Incorrect_Number_Of_Iovec_Members);

+ static_assert(5 == kCrashIovSize - 1, "kCrashIovSize should equal 6");

#else

iov[6].iov_base = asan_report.get();

iov[6].iov_len = kMaxAsanReportSize + 1;

- COMPILE_ASSERT(6 == kCrashIovSize - 1, Incorrect_Number_Of_Iovec_Members);

+ static_assert(6 == kCrashIovSize - 1, "kCrashIovSize should equal 7");

#endif

msg.msg_iov = iov;

msg.msg_iovlen = kCrashIovSize;