components/variations/metrics_util.cc - Issue 794683005: replace COMPILE_ASSERT with static_assert in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/variations/metrics_util.cc

Issue 794683005: replace COMPILE_ASSERT with static_assert in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: formatting fixup Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/variations/metrics_util.cc

diff --git a/components/variations/metrics_util.cc b/components/variations/metrics_util.cc

index 031c3d37a31311794a33aef7bc09497a0e0fa5f3..41b2df3854a94866994fd723cfeb78e014346b66 100644

--- a/components/variations/metrics_util.cc

+++ b/components/variations/metrics_util.cc

@@ -18,7 +18,7 @@ uint32 HashName(const std::string& name) {

sha1_hash);

uint32 bits;

- COMPILE_ASSERT(sizeof(bits) < sizeof(sha1_hash), need_more_data);

+ static_assert(sizeof(bits) < sizeof(sha1_hash), "more data required");

memcpy(&bits, sha1_hash, sizeof(bits));

return base::ByteSwapToLE32(bits);

« no previous file with comments | « components/variations/entropy_provider.cc ('k') | no next file » | no next file with comments »