Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Side by Side Diff: components/translate/core/common/translate_metrics.cc

Issue 794683005: replace COMPILE_ASSERT with static_assert in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: formatting fixup Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/translate/core/common/translate_metrics.h" 5 #include "components/translate/core/common/translate_metrics.h"
6 6
7 #include "base/basictypes.h" 7 #include "base/basictypes.h"
8 #include "base/metrics/histogram.h" 8 #include "base/metrics/histogram.h"
9 #include "url/url_constants.h" 9 #include "url/url_constants.h"
10 10
(...skipping 25 matching lines...) Expand all
36 {UMA_CONTENT_LANGUAGE, kTranslateContentLanguage}, 36 {UMA_CONTENT_LANGUAGE, kTranslateContentLanguage},
37 {UMA_HTML_LANG, kTranslateHtmlLang}, 37 {UMA_HTML_LANG, kTranslateHtmlLang},
38 {UMA_LANGUAGE_VERIFICATION, kTranslateLanguageVerification}, 38 {UMA_LANGUAGE_VERIFICATION, kTranslateLanguageVerification},
39 {UMA_TIME_TO_BE_READY, kTranslateTimeToBeReady}, 39 {UMA_TIME_TO_BE_READY, kTranslateTimeToBeReady},
40 {UMA_TIME_TO_LOAD, kTranslateTimeToLoad}, 40 {UMA_TIME_TO_LOAD, kTranslateTimeToLoad},
41 {UMA_TIME_TO_TRANSLATE, kTranslateTimeToTranslate}, 41 {UMA_TIME_TO_TRANSLATE, kTranslateTimeToTranslate},
42 {UMA_USER_ACTION_DURATION, kTranslateUserActionDuration}, 42 {UMA_USER_ACTION_DURATION, kTranslateUserActionDuration},
43 {UMA_PAGE_SCHEME, kTranslatePageScheme}, 43 {UMA_PAGE_SCHEME, kTranslatePageScheme},
44 {UMA_SIMILAR_LANGUAGE_MATCH, kTranslateSimilarLanguageMatch}, }; 44 {UMA_SIMILAR_LANGUAGE_MATCH, kTranslateSimilarLanguageMatch}, };
45 45
46 COMPILE_ASSERT(arraysize(kMetricsEntries) == UMA_MAX, 46 static_assert(arraysize(kMetricsEntries) == UMA_MAX,
47 arraysize_of_kMetricsEntries_should_be_UMA_MAX); 47 "kMetricsEntries should have UMA_MAX elements");
48 48
49 LanguageCheckType GetLanguageCheckMetric(const std::string& provided_code, 49 LanguageCheckType GetLanguageCheckMetric(const std::string& provided_code,
50 const std::string& revised_code) { 50 const std::string& revised_code) {
51 if (provided_code.empty()) 51 if (provided_code.empty())
52 return LANGUAGE_NOT_PROVIDED; 52 return LANGUAGE_NOT_PROVIDED;
53 else if (provided_code == revised_code) 53 else if (provided_code == revised_code)
54 return LANGUAGE_VALID; 54 return LANGUAGE_VALID;
55 return LANGUAGE_INVALID; 55 return LANGUAGE_INVALID;
56 } 56 }
57 57
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
122 const char* GetMetricsName(MetricsNameIndex index) { 122 const char* GetMetricsName(MetricsNameIndex index) {
123 for (size_t i = 0; i < arraysize(kMetricsEntries); ++i) { 123 for (size_t i = 0; i < arraysize(kMetricsEntries); ++i) {
124 if (kMetricsEntries[i].index == index) 124 if (kMetricsEntries[i].index == index)
125 return kMetricsEntries[i].name; 125 return kMetricsEntries[i].name;
126 } 126 }
127 NOTREACHED(); 127 NOTREACHED();
128 return NULL; 128 return NULL;
129 } 129 }
130 130
131 } // namespace translate 131 } // namespace translate
OLDNEW
« no previous file with comments | « components/translate/core/browser/translate_browser_metrics.cc ('k') | components/user_manager/user.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698