Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 789243002: Restructure public side of network service. (Closed)

Created:
6 years ago by blundell
Modified:
6 years ago
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, esprehn, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, ojan
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Restructure public side of network service. This CL goes from this: //mojo/services/public/cpp/network //mojo/services/public/interfaces/network to this: //mojo/services/network/public/cpp //mojo/services/network/public/interfaces This CL also makes the Mojo-side changes required to roll this change into Chromium. TBR=beng Committed: https://chromium.googlesource.com/external/mojo/+/b470fa115a98682e0e67f1c1c5a1817ba49672eb

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Nit #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -1211 lines) Patch
M examples/js/README.md View 1 chunk +1 line, -1 line 0 comments Download
M examples/js/wget.js View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/pdf_viewer/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M examples/png_viewer/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M examples/recursive_content_handler/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M examples/wget/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M examples/wget/wget.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/application/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/application/content_handler_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/application_manager/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
M mojo/application_manager/application_loader.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M mojo/services/network/BUILD.gn View 1 2 3 3 chunks +6 lines, -6 lines 0 comments Download
M mojo/services/network/cookie_store_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/net_adapters.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/net_address_type_converters.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/network_service_impl.h View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/network/public/cpp/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
A + mojo/services/network/public/cpp/udp_socket_wrapper.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + mojo/services/network/public/cpp/udp_socket_wrapper.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/network/public/cpp/web_socket_read_queue.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/services/network/public/cpp/web_socket_read_queue.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/network/public/cpp/web_socket_write_queue.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/services/network/public/cpp/web_socket_write_queue.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/network/public/interfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/network/public/interfaces/cookie_store.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/services/network/public/interfaces/net_address.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/services/network/public/interfaces/network_error.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/services/network/public/interfaces/network_service.mojom View 1 chunk +8 lines, -8 lines 0 comments Download
A + mojo/services/network/public/interfaces/tcp_bound_socket.mojom View 1 chunk +4 lines, -4 lines 0 comments Download
A + mojo/services/network/public/interfaces/tcp_connected_socket.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/services/network/public/interfaces/tcp_server_socket.mojom View 1 chunk +3 lines, -3 lines 0 comments Download
A + mojo/services/network/public/interfaces/udp_socket.mojom View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/services/network/public/interfaces/url_loader.mojom View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/network/public/interfaces/web_socket.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/tcp_bound_socket_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/tcp_connected_socket_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/tcp_server_socket_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/udp_socket_apptest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/services/network/udp_socket_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/url_loader_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/web_socket_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/web_socket_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D mojo/services/public/cpp/network/BUILD.gn View 1 chunk +0 lines, -24 lines 0 comments Download
D mojo/services/public/cpp/network/udp_socket_wrapper.h View 1 chunk +0 lines, -145 lines 0 comments Download
D mojo/services/public/cpp/network/udp_socket_wrapper.cc View 1 chunk +0 lines, -207 lines 0 comments Download
D mojo/services/public/cpp/network/web_socket_read_queue.h View 1 chunk +0 lines, -42 lines 0 comments Download
D mojo/services/public/cpp/network/web_socket_read_queue.cc View 1 chunk +0 lines, -70 lines 0 comments Download
D mojo/services/public/cpp/network/web_socket_write_queue.h View 1 chunk +0 lines, -44 lines 0 comments Download
D mojo/services/public/cpp/network/web_socket_write_queue.cc View 1 chunk +0 lines, -84 lines 0 comments Download
M mojo/services/public/interfaces/content_handler/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/public/interfaces/content_handler/content_handler.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/public/interfaces/navigation/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/public/interfaces/navigation/navigation.mojom View 1 chunk +1 line, -1 line 0 comments Download
D mojo/services/public/interfaces/network/BUILD.gn View 1 chunk +0 lines, -20 lines 0 comments Download
D mojo/services/public/interfaces/network/cookie_store.mojom View 1 chunk +0 lines, -10 lines 0 comments Download
D mojo/services/public/interfaces/network/net_address.mojom View 1 chunk +0 lines, -39 lines 0 comments Download
D mojo/services/public/interfaces/network/network_error.mojom View 1 chunk +0 lines, -10 lines 0 comments Download
D mojo/services/public/interfaces/network/network_service.mojom View 1 chunk +0 lines, -61 lines 0 comments Download
D mojo/services/public/interfaces/network/tcp_bound_socket.mojom View 1 chunk +0 lines, -39 lines 0 comments Download
D mojo/services/public/interfaces/network/tcp_connected_socket.mojom View 1 chunk +0 lines, -14 lines 0 comments Download
D mojo/services/public/interfaces/network/tcp_server_socket.mojom View 1 chunk +0 lines, -26 lines 0 comments Download
D mojo/services/public/interfaces/network/udp_socket.mojom View 1 chunk +0 lines, -106 lines 0 comments Download
D mojo/services/public/interfaces/network/url_loader.mojom View 1 chunk +0 lines, -104 lines 0 comments Download
D mojo/services/public/interfaces/network/web_socket.mojom View 1 chunk +0 lines, -60 lines 0 comments Download
M mojo/services/public/mojo_services_public.gyp View 1 chunk +11 lines, -11 lines 0 comments Download
M mojo/tools/package_manager/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/tools/package_manager/package_fetcher.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/tools/package_manager/package_fetcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/tools/package_manager/package_manager_application.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/tools/roll/rev_sdk.py View 1 chunk +1 line, -0 lines 0 comments Download
M services/http_server/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/http_server/http_server.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/js/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M shell/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M shell/dynamic_application_loader.h View 1 chunk +1 line, -1 line 0 comments Download
M shell/dynamic_application_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/platform/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/platform/fetcher/MojoFetcher.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/platform/fetcher/MojoFetcher.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/framework/xmlhttprequest.sky View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tests/services/network.sky View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/viewer/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M sky/viewer/content_handler_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M sky/viewer/converters/url_request_types.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/viewer/document_view.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/viewer/platform/platform_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/viewer/platform/weburlloader_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/viewer/platform/weburlloader_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
blundell
the hits keep on coming
6 years ago (2014-12-10 15:13:57 UTC) #1
blundell
Committed patchset #4 (id:60001) manually as b470fa115a98682e0e67f1c1c5a1817ba49672eb (presubmit successful).
6 years ago (2014-12-10 15:28:48 UTC) #2
Ben Goodger (Google)
6 years ago (2014-12-10 21:36:31 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698