Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 777673003: move program descriptor generation to flush (Closed)

Created:
6 years ago by joshua.litt
Modified:
6 years ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : first draft #

Patch Set 3 : bleanup #

Patch Set 4 : one last cleanup #

Patch Set 5 : more cleanup #

Total comments: 1

Patch Set 6 : fix #

Total comments: 1

Patch Set 7 : feedback inc #

Patch Set 8 : fix builder bug #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -133 lines) Patch
M src/gpu/GrGpu.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrGpu.cpp View 1 2 3 4 5 4 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.h View 1 2 3 4 5 1 chunk +5 lines, -5 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.cpp View 1 2 3 4 5 3 chunks +4 lines, -2 lines 0 comments Download
M src/gpu/GrOptDrawState.h View 1 2 3 4 5 6 4 chunks +12 lines, -23 lines 0 comments Download
M src/gpu/GrOptDrawState.cpp View 1 2 3 4 5 6 7 8 chunks +47 lines, -49 lines 0 comments Download
M src/gpu/GrProgramDesc.h View 1 2 3 4 5 6 7 2 chunks +13 lines, -2 lines 0 comments Download
M src/gpu/GrTest.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLProgram.h View 1 2 3 4 5 3 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 1 2 3 4 5 5 chunks +8 lines, -11 lines 0 comments Download
M src/gpu/gl/GrGLProgramDesc.cpp View 1 2 3 4 5 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGpuGL.h View 1 2 3 4 5 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGpuGL.cpp View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGpuGL_program.cpp View 1 2 3 4 5 5 chunks +9 lines, -9 lines 0 comments Download
M src/gpu/gl/builders/GrGLGeometryShaderBuilder.cpp View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.h View 1 2 3 4 5 2 chunks +1 line, -2 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 1 2 3 4 5 3 chunks +2 lines, -8 lines 0 comments Download
M tests/GLProgramsTest.cpp View 1 2 3 4 5 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
joshualitt
Undoing the early creation of program descriptor
6 years ago (2014-12-03 18:04:06 UTC) #2
bsalomon
https://codereview.chromium.org/777673003/diff/80001/src/gpu/GrInOrderDrawBuffer.h File src/gpu/GrInOrderDrawBuffer.h (right): https://codereview.chromium.org/777673003/diff/80001/src/gpu/GrInOrderDrawBuffer.h#newcode258 src/gpu/GrInOrderDrawBuffer.h:258: GrProgramDesc fDesc; shouldn't this be a local in onflush()?
6 years ago (2014-12-03 18:41:08 UTC) #3
joshualitt
On 2014/12/03 18:41:08, bsalomon wrote: > https://codereview.chromium.org/777673003/diff/80001/src/gpu/GrInOrderDrawBuffer.h > File src/gpu/GrInOrderDrawBuffer.h (right): > > https://codereview.chromium.org/777673003/diff/80001/src/gpu/GrInOrderDrawBuffer.h#newcode258 > ...
6 years ago (2014-12-03 19:11:30 UTC) #4
bsalomon
lgtm
6 years ago (2014-12-03 19:39:45 UTC) #5
egdaniel
https://codereview.chromium.org/777673003/diff/100001/src/gpu/GrOptDrawState.h File src/gpu/GrOptDrawState.h (right): https://codereview.chromium.org/777673003/diff/100001/src/gpu/GrOptDrawState.h#newcode196 src/gpu/GrOptDrawState.h:196: void computeEffectiveColorStages(const GrDrawState& ds, int* firstColorStageIdx, This function and ...
6 years ago (2014-12-03 19:42:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/777673003/120001
6 years ago (2014-12-03 21:48:45 UTC) #8
commit-bot: I haz the power
Committed patchset #7 (id:120001) as https://skia.googlesource.com/skia/+/829e1b80b1020b17f2078020c990e079b70c077c
6 years ago (2014-12-03 21:57:41 UTC) #9
joshualitt
A revert of this CL (patchset #7 id:120001) has been created in https://codereview.chromium.org/776243005/ by joshualitt@google.com. ...
6 years ago (2014-12-04 14:01:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/777673003/140001
6 years ago (2014-12-04 16:50:03 UTC) #12
commit-bot: I haz the power
6 years ago (2014-12-04 16:59:15 UTC) #13
Message was sent while issue was closed. 
Committed patchset #8 (id:140001) as
https://skia.googlesource.com/skia/+/dafa4d09cbe66943b2414bdeaa0f6ef7f900dc4a

Powered by Google App Engine
This is Rietveld 408576698