src/gpu/gl/builders/GrGLProgramBuilder.h - Issue 777673003: move program descriptor generation to flush

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/gl/builders/GrGLProgramBuilder.h

Issue 777673003: move program descriptor generation to flush (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: fix builder bug Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/gpu/gl/builders/GrGLProgramBuilder.h

diff --git a/src/gpu/gl/builders/GrGLProgramBuilder.h b/src/gpu/gl/builders/GrGLProgramBuilder.h

index 76f7ae97c37df5c5091712cb75767da81e6b84bc..973ae5e07820a1e24cb228980983f4d0500d8c44 100644

--- a/src/gpu/gl/builders/GrGLProgramBuilder.h

+++ b/src/gpu/gl/builders/GrGLProgramBuilder.h

@@ -186,7 +186,7 @@ public:

* to be used.

* @return true if generation was successful.

- static GrGLProgram* CreateProgram(const GrOptDrawState&, GrGpu::DrawType, GrGpuGL*);

+ static GrGLProgram* CreateProgram(const GrOptDrawState&, GrGpuGL*);

virtual UniformHandle addUniform(uint32_t visibility,

GrSLType type,

@@ -246,7 +246,6 @@ protected:

typedef GrGLProgramDataManager::UniformInfoArray UniformInfoArray;

static GrGLProgramBuilder* CreateProgramBuilder(const GrOptDrawState&,

- GrGpu::DrawType,

bool hasGeometryProcessor,

GrGpuGL*);