Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1104)

Issue 757873003: Check that usage isn't empty when generateKey() is called (Closed)

Created:
6 years ago by nharper
Modified:
6 years ago
Reviewers:
pdr., eroman
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Check that usage isn't empty when generateKey() is called This is my second attempt at https://codereview.chromium.org/745443002/, after it was reverted. The broken test that caused it to get reverted was fixed in https://codereview.chromium.org/757813002/. BUG=425645 Committed: https://crrev.com/70f820af8eb1f642a0a5e7df8dd4c3a3c269de29 Cr-Commit-Position: refs/heads/master@{#306667}

Patch Set 1 #

Patch Set 2 : rebase and fix bad merges #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -38 lines) Patch
M content/child/webcrypto/nss/rsa_key_nss.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/child/webcrypto/nss/sym_key_nss.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/child/webcrypto/openssl/ec_key_openssl.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/child/webcrypto/openssl/rsa_key_openssl.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/child/webcrypto/openssl/sym_key_openssl.cc View 1 2 chunks +9 lines, -3 lines 0 comments Download
M content/child/webcrypto/status.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/child/webcrypto/status.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M content/child/webcrypto/test/aes_cbc_unittest.cc View 1 4 chunks +13 lines, -4 lines 0 comments Download
M content/child/webcrypto/test/aes_gcm_unittest.cc View 1 1 chunk +12 lines, -1 line 0 comments Download
M content/child/webcrypto/test/aes_kw_unittest.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M content/child/webcrypto/test/ecdsa_unittest.cc View 2 chunks +15 lines, -2 lines 0 comments Download
M content/child/webcrypto/test/hmac_unittest.cc View 4 chunks +17 lines, -3 lines 0 comments Download
M content/child/webcrypto/test/rsa_ssa_unittest.cc View 1 11 chunks +52 lines, -25 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
nharper
I attempted to run the mac_blink_rel try job, but its result was an exception. If ...
6 years ago (2014-11-26 18:46:04 UTC) #2
eroman
LGTM. That bot might just be broken. I sent it to some other mac blink ...
6 years ago (2014-11-26 20:10:15 UTC) #3
eroman
The test passed on mac_blink_dbg, I consider that sufficient proof.
6 years ago (2014-11-26 20:55:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/757873003/1
6 years ago (2014-11-26 20:57:23 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/9442)
6 years ago (2014-11-26 21:48:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/757873003/20001
6 years ago (2014-12-03 19:14:37 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-03 20:36:18 UTC) #11
commit-bot: I haz the power
6 years ago (2014-12-03 20:36:52 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/70f820af8eb1f642a0a5e7df8dd4c3a3c269de29
Cr-Commit-Position: refs/heads/master@{#306667}

Powered by Google App Engine
This is Rietveld 408576698