Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: content/child/webcrypto/test/ecdsa_unittest.cc

Issue 757873003: Check that usage isn't empty when generateKey() is called (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase and fix bad merges Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/child/webcrypto/test/aes_kw_unittest.cc ('k') | content/child/webcrypto/test/hmac_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/webcrypto/test/ecdsa_unittest.cc
diff --git a/content/child/webcrypto/test/ecdsa_unittest.cc b/content/child/webcrypto/test/ecdsa_unittest.cc
index b81a9edc95d7a2f8cb4b036b0666738e9df1f219..5952fbfdb6b75bccaba7faedf8e0a1825a3ba632 100644
--- a/content/child/webcrypto/test/ecdsa_unittest.cc
+++ b/content/child/webcrypto/test/ecdsa_unittest.cc
@@ -64,8 +64,9 @@ TEST(WebCryptoEcdsaTest, GenerateKeyIsRandom) {
blink::WebCryptoKey private_key;
ASSERT_EQ(Status::Success(),
- GenerateKeyPair(CreateEcdsaKeyGenAlgorithm(named_curve), true, 0,
- &public_key, &private_key));
+ GenerateKeyPair(CreateEcdsaKeyGenAlgorithm(named_curve), true,
+ blink::WebCryptoKeyUsageSign, &public_key,
+ &private_key));
// Basic sanity checks on the generated key pair.
EXPECT_EQ(blink::WebCryptoKeyTypePublic, public_key.type());
@@ -89,6 +90,18 @@ TEST(WebCryptoEcdsaTest, GenerateKeyIsRandom) {
EXPECT_FALSE(CopiesExist(serialized_keys));
}
+TEST(WebCryptoEcdsaTest, GenerateKeyEmptyUsage) {
+ if (!SupportsEcdsa())
+ return;
+
+ blink::WebCryptoNamedCurve named_curve = blink::WebCryptoNamedCurveP256;
+ blink::WebCryptoKey public_key;
+ blink::WebCryptoKey private_key;
+ ASSERT_EQ(Status::ErrorCreateKeyEmptyUsages(),
+ GenerateKeyPair(CreateEcdsaKeyGenAlgorithm(named_curve), true, 0,
+ &public_key, &private_key));
+}
+
// Verify that ECDSA signatures are probabilistic. Signing the same message two
// times should yield different signatures. However both signatures should
// verify correctly.
« no previous file with comments | « content/child/webcrypto/test/aes_kw_unittest.cc ('k') | content/child/webcrypto/test/hmac_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698