Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 757813002: [webcrypto] Add key usage to rsa-oaep generate key test (Closed)

Created:
6 years ago by nharper
Modified:
6 years ago
Reviewers:
pdr., eroman
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[webcrypto] Add key usage to rsa-oaep generate key test BUG=425645 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185964

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M LayoutTests/crypto/rsa-oaep-generate-non-extractable-key.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
nharper
This fixes the test that failed when https://codereview.chromium.org/745443002/ was submitted.
6 years ago (2014-11-25 00:37:45 UTC) #2
eroman
lgtm
6 years ago (2014-11-25 01:07:37 UTC) #3
pdr.
On 2014/11/25 at 01:07:37, eroman wrote: > lgtm Can you try kicking off a tryjob ...
6 years ago (2014-11-25 01:09:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/757813002/1
6 years ago (2014-11-25 01:09:06 UTC) #6
eroman
I believe it is the Mac layout tests which failed. The blink trybots should test ...
6 years ago (2014-11-25 01:13:12 UTC) #8
pdr.
On 2014/11/25 at 01:13:12, eroman wrote: > I believe it is the Mac layout tests ...
6 years ago (2014-11-25 01:15:00 UTC) #9
eroman
And Nick before re-committing the Chromium side which broke the LayoutTest, click the "try more ...
6 years ago (2014-11-25 01:33:38 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/757813002/1
6 years ago (2014-11-25 18:56:34 UTC) #12
commit-bot: I haz the power
6 years ago (2014-11-25 19:29:41 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=185964

Powered by Google App Engine
This is Rietveld 408576698