Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1616)

Unified Diff: content/child/webcrypto/nss/rsa_key_nss.cc

Issue 757873003: Check that usage isn't empty when generateKey() is called (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase and fix bad merges Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/child/webcrypto/nss/sym_key_nss.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/webcrypto/nss/rsa_key_nss.cc
diff --git a/content/child/webcrypto/nss/rsa_key_nss.cc b/content/child/webcrypto/nss/rsa_key_nss.cc
index 1cbf6b0d806532c9fcd1569e5dd49f9d4756e349..7a35593c18bdd75b2bfd5d7cd6e29704aa5f069b 100644
--- a/content/child/webcrypto/nss/rsa_key_nss.cc
+++ b/content/child/webcrypto/nss/rsa_key_nss.cc
@@ -513,6 +513,9 @@ Status RsaHashedAlgorithm::GenerateKey(
const blink::WebCryptoKeyUsageMask private_usages =
combined_usages & all_private_key_usages_;
+ if (private_usages == 0)
+ return Status::ErrorCreateKeyEmptyUsages();
+
unsigned int public_exponent = 0;
unsigned int modulus_length_bits = 0;
status = GetRsaKeyGenParameters(algorithm.rsaHashedKeyGenParams(),
« no previous file with comments | « no previous file | content/child/webcrypto/nss/sym_key_nss.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698