Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1687)

Unified Diff: content/child/webcrypto/openssl/ec_key_openssl.cc

Issue 757873003: Check that usage isn't empty when generateKey() is called (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase and fix bad merges Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/child/webcrypto/nss/sym_key_nss.cc ('k') | content/child/webcrypto/openssl/rsa_key_openssl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/webcrypto/openssl/ec_key_openssl.cc
diff --git a/content/child/webcrypto/openssl/ec_key_openssl.cc b/content/child/webcrypto/openssl/ec_key_openssl.cc
index 8d5fc0879d70227c6c687918cb3515dce2b73af4..81e233701f42767301e104023301db12f4942f6f 100644
--- a/content/child/webcrypto/openssl/ec_key_openssl.cc
+++ b/content/child/webcrypto/openssl/ec_key_openssl.cc
@@ -218,6 +218,9 @@ Status EcAlgorithm::GenerateKey(const blink::WebCryptoAlgorithm& algorithm,
const blink::WebCryptoKeyUsageMask private_usages =
combined_usages & all_private_key_usages_;
+ if (private_usages == 0)
+ return Status::ErrorCreateKeyEmptyUsages();
+
const blink::WebCryptoEcKeyGenParams* params = algorithm.ecKeyGenParams();
crypto::OpenSSLErrStackTracer err_tracer(FROM_HERE);
« no previous file with comments | « content/child/webcrypto/nss/sym_key_nss.cc ('k') | content/child/webcrypto/openssl/rsa_key_openssl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698