Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Unified Diff: content/child/webcrypto/openssl/rsa_key_openssl.cc

Issue 757873003: Check that usage isn't empty when generateKey() is called (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase and fix bad merges Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/webcrypto/openssl/rsa_key_openssl.cc
diff --git a/content/child/webcrypto/openssl/rsa_key_openssl.cc b/content/child/webcrypto/openssl/rsa_key_openssl.cc
index 49f57e729e1d2a60ac3d175726a121e9a30abfcf..09e277f261f71d910379228d3f4921c0faa2160f 100644
--- a/content/child/webcrypto/openssl/rsa_key_openssl.cc
+++ b/content/child/webcrypto/openssl/rsa_key_openssl.cc
@@ -167,6 +167,9 @@ Status RsaHashedAlgorithm::GenerateKey(
const blink::WebCryptoKeyUsageMask private_usages =
combined_usages & all_private_key_usages_;
+ if (private_usages == 0)
+ return Status::ErrorCreateKeyEmptyUsages();
+
const blink::WebCryptoRsaHashedKeyGenParams* params =
algorithm.rsaHashedKeyGenParams();
« no previous file with comments | « content/child/webcrypto/openssl/ec_key_openssl.cc ('k') | content/child/webcrypto/openssl/sym_key_openssl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698