Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 755363002: remove proc key (Closed)

Created:
6 years ago by joshua.litt
Modified:
6 years ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@fixkey
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : more cleanup #

Patch Set 3 : more cleanup #

Patch Set 4 : address nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -168 lines) Patch
M include/gpu/GrBackendProcessorFactory.h View 1 2 1 chunk +0 lines, -25 lines 0 comments Download
M src/core/SkXfermode.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/effects/SkAlphaThresholdFilter.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M src/effects/SkArithmeticMode.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 4 chunks +0 lines, -4 lines 0 comments Download
M src/effects/SkColorCubeFilter.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M src/effects/SkColorFilters.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/effects/SkColorMatrixFilter.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M src/effects/SkLumaColorFilter.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/effects/SkMagnifierImageFilter.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M src/effects/SkPerlinNoiseShader.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M src/effects/SkTableColorFilter.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M src/effects/gradients/SkGradientShader.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkLinearGradient.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M src/effects/gradients/SkRadialGradient.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M src/effects/gradients/SkSweepGradient.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient_gpu.cpp View 10 chunks +0 lines, -10 lines 0 comments Download
M src/effects/gradients/SkTwoPointRadialGradient.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M src/gpu/GrProgramDesc.h View 1 chunk +0 lines, -39 lines 0 comments Download
M src/gpu/effects/GrBicubicEffect.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/effects/GrConvexPolyEffect.cpp View 4 chunks +0 lines, -4 lines 0 comments Download
M src/gpu/effects/GrConvolutionEffect.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M src/gpu/effects/GrDitherEffect.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M src/gpu/effects/GrMatrixConvolutionEffect.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M src/gpu/effects/GrOvalEffect.cpp View 4 chunks +0 lines, -4 lines 0 comments Download
M src/gpu/effects/GrRRectEffect.cpp View 4 chunks +5 lines, -9 lines 0 comments Download
M src/gpu/effects/GrSimpleTextureEffect.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/effects/GrTextureDomain.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M src/gpu/effects/GrYUVtoRGBEffect.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLGeometryProcessor.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/gpu/gl/GrGLProcessor.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.h View 2 chunks +0 lines, -4 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 6 chunks +5 lines, -15 lines 0 comments Download
M tests/GLProgramsTest.cpp View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
joshualitt
6 years ago (2014-11-25 21:54:30 UTC) #2
bsalomon
lgtm
6 years ago (2014-11-25 22:00:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/755363002/60001
6 years ago (2014-11-25 22:43:18 UTC) #5
commit-bot: I haz the power
6 years ago (2014-11-25 22:52:25 UTC) #6
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/267ce482b54f46097584e0f9350ec74aa6a2cd44

Powered by Google App Engine
This is Rietveld 408576698