Remove several uses of toWebCoreStringWithNullCheck(v8::Handle<v8::Value>)

Remove several uses of toWebCoreStringWithNullCheck(v8::Handle<v8::Value>)

Remove several uses of toWebCoreStringWithNullCheck(v8::Handle<v8::Value>) and replace by
the V8TRYCATCH_FOR_V8STRINGRESOURCE_*() macros. This makes sure that we properly abort
execution when an exception is thrown by v8::Value::ToString().

R=haraken
TEST=fast/dom/CSSStyleDeclaration/css-style-declaration-named-setter.html
TEST=fast/frames/frame-set-location-badstring.html
TEST=fast/xmlhttprequest/xmlhttprequest-open-exceptions.html
TEST=http/tests/local/formdata/send-form-data-with-bad-string.html

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162150

[haraken, 2013-11-15 22:20:15]

LGTM. Thanks for tests.

https://codereview.chromium.org/74133005/diff/1/Source/bindings/v8/custom/V8F...
File Source/bindings/v8/custom/V8FormDataCustom.cpp (right):

https://codereview.chromium.org/74133005/diff/1/Source/bindings/v8/custom/V8F...
Source/bindings/v8/custom/V8FormDataCustom.cpp:60:
V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<WithUndefinedOrNullCheck>,
filenameResource, info[2]);

Not related to your CL, it looks inconsistent that we have an Undefined check
only for the third parameter. Is this behavior speced?

[Inactive, 2013-11-15 22:30:24]

https://codereview.chromium.org/74133005/diff/1/Source/bindings/v8/custom/V8F...
File Source/bindings/v8/custom/V8FormDataCustom.cpp (right):

https://codereview.chromium.org/74133005/diff/1/Source/bindings/v8/custom/V8F...
Source/bindings/v8/custom/V8FormDataCustom.cpp:60:
V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<WithUndefinedOrNullCheck>,
filenameResource, info[2]);
On 2013/11/15 22:20:15, haraken wrote:
> 
> Not related to your CL, it looks inconsistent that we have an Undefined check
> only for the third parameter. Is this behavior speced?

Only the last argument is optional, doesn't it make sense that:
FormData.append(x, blob, undefined)
is equivalent to:
FormData.append(x, blob) ?

Here is the specification link:
http://xhr.spec.whatwg.org/#interface-formdata

[haraken, 2013-11-15 22:33:39]

https://codereview.chromium.org/74133005/diff/1/Source/bindings/v8/custom/V8F...
File Source/bindings/v8/custom/V8FormDataCustom.cpp (right):

https://codereview.chromium.org/74133005/diff/1/Source/bindings/v8/custom/V8F...
Source/bindings/v8/custom/V8FormDataCustom.cpp:60:
V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<WithUndefinedOrNullCheck>,
filenameResource, info[2]);
On 2013/11/15 22:30:25, Chris Dumez wrote:
> On 2013/11/15 22:20:15, haraken wrote:
> > 
> > Not related to your CL, it looks inconsistent that we have an Undefined
check
> > only for the third parameter. Is this behavior speced?
> 
> Only the last argument is optional, doesn't it make sense that:
> FormData.append(x, blob, undefined)
> is equivalent to:
> FormData.append(x, blob) ?
> 
> Here is the specification link:
> http://xhr.spec.whatwg.org/#interface-formdata

Makes sense. Thanks for the clarification!

[commit-bot: I haz the power, 2013-11-15 22:35:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/74133005/1

[commit-bot: I haz the power, 2013-11-16 00:18:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/74133005/1

[commit-bot: I haz the power, 2013-11-16 02:38:55]

Change committed as 162150