Remove several uses of toWebCoreStringWithNullCheck(v8::Handle<v8::Value>)

Source/bindings/v8/custom/V8InspectorFrontendHostCustom.cpp

 /*
  * Copyright (C) 2007-2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 38 matching lines @@
     v8SetReturnValue(info, v8::String::NewSymbol("windows"));
 #else // Unix-like systems
     v8SetReturnValue(info, v8::String::NewSymbol("linux"));
 #endif
 }
 
 void V8InspectorFrontendHost::portMethodCustom(const v8::FunctionCallbackInfo<v8::Value>&)
 {
 }
 
-static void populateContextMenuItems(v8::Local<v8::Array>& itemArray, ContextMenu& menu)
+static bool populateContextMenuItems(v8::Local<v8::Array>& itemArray, ContextMenu& menu)
 {
     for (size_t i = 0; i < itemArray->Length(); ++i) {
         v8::Local<v8::Object> item = v8::Local<v8::Object>::Cast(itemArray->Get(i));
         v8::Local<v8::Value> type = item->Get(v8::String::NewSymbol("type"));
         v8::Local<v8::Value> id = item->Get(v8::String::NewSymbol("id"));
         v8::Local<v8::Value> label = item->Get(v8::String::NewSymbol("label"));
         v8::Local<v8::Value> enabled = item->Get(v8::String::NewSymbol("enabled"));
         v8::Local<v8::Value> checked = item->Get(v8::String::NewSymbol("checked"));
         v8::Local<v8::Value> subItems = item->Get(v8::String::NewSymbol("subItems"));
         if (!type->IsString())
             continue;
         String typeString = toWebCoreStringWithNullCheck(type.As<v8::String>());
         if (typeString == "separator") {
             ContextMenuItem item(ContextMenuItem(SeparatorType,
                                  ContextMenuItemCustomTagNoAction,
                                  String()));
             menu.appendItem(item);
         } else if (typeString == "subMenu" && subItems->IsArray()) {
             ContextMenu subMenu;
             v8::Local<v8::Array> subItemsArray = v8::Local<v8::Array>::Cast(subItems);
-            populateContextMenuItems(subItemsArray, subMenu);
+            if (!populateContextMenuItems(subItemsArray, subMenu))
+                return false;
+            V8TRYCATCH_FOR_V8STRINGRESOURCE_RETURN(V8StringResource<WithNullCheck>, labelString, label, false);
             ContextMenuItem item(SubmenuType,
-                                 ContextMenuItemCustomTagNoAction,
-                                 toWebCoreStringWithNullCheck(label),
-                                 &subMenu);
+                ContextMenuItemCustomTagNoAction,
+                labelString,
+                &subMenu);
             menu.appendItem(item);
         } else {
             ContextMenuAction typedId = static_cast<ContextMenuAction>(ContextMenuItemBaseCustomTag + id->ToInt32()->Value());
             ContextMenuItem menuItem((typeString == "checkbox" ? CheckableActionType : ActionType), typedId, toWebCoreStringWithNullCheck(label));
             if (checked->IsBoolean())
                 menuItem.setChecked(checked->ToBoolean()->Value());
             if (enabled->IsBoolean())
                 menuItem.setEnabled(enabled->ToBoolean()->Value());
             menu.appendItem(menuItem);
         }
     }
+    return true;
 }
 
 void V8InspectorFrontendHost::showContextMenuMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& info)
 {
     if (info.Length() < 2)
         return;
 
     v8::Local<v8::Object> eventWrapper = v8::Local<v8::Object>::Cast(info[0]);
     if (!V8MouseEvent::wrapperTypeInfo.equals(toWrapperTypeInfo(eventWrapper)))
         return;
 
     Event* event = V8Event::toNative(eventWrapper);
     if (!info[1]->IsArray())
         return;
 
     v8::Local<v8::Array> array = v8::Local<v8::Array>::Cast(info[1]);
     ContextMenu menu;
-    populateContextMenuItems(array, menu);
+    if (!populateContextMenuItems(array, menu))
+        return;
 
     InspectorFrontendHost* frontendHost = V8InspectorFrontendHost::toNative(info.Holder());
     Vector<ContextMenuItem> items = menu.items();
     frontendHost->showContextMenu(event, items);
 }
 
 static void histogramEnumeration(const char* name, const v8::FunctionCallbackInfo<v8::Value>& info, int boundaryValue)
 {
     if (info.Length() < 1 || !info[0]->IsInt32())
         return;
@@ skipping 13 matching lines @@
     histogramEnumeration("DevTools.PanelShown", info, 20);
 }
 
 void V8InspectorFrontendHost::recordSettingChangedMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& info)
 {
     histogramEnumeration("DevTools.SettingChanged", info, 100);
 }
 
 } // namespace WebCore