LayoutTests/fast/dom/CSSStyleDeclaration/css-style-declaration-named-setter.html - Issue 74133005: Remove several uses of toWebCoreStringWithNullCheck(v8::Handle<v8::Value>)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/dom/CSSStyleDeclaration/css-style-declaration-named-setter.html

Issue 74133005: Remove several uses of toWebCoreStringWithNullCheck(v8::Handle<v8::Value>) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | LayoutTests/fast/dom/CSSStyleDeclaration/css-style-declaration-named-setter-expected.txt » ('j') | Source/bindings/v8/custom/V8FormDataCustom.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/dom/CSSStyleDeclaration/css-style-declaration-named-setter.html

diff --git a/LayoutTests/fast/dom/CSSStyleDeclaration/css-style-declaration-named-setter.html b/LayoutTests/fast/dom/CSSStyleDeclaration/css-style-declaration-named-setter.html

index a6ee0112cae6b066bd244bf0cf7679998063a623..a7186cc38b3edd16e1c72b757c9fe5ae3927efda 100644

--- a/LayoutTests/fast/dom/CSSStyleDeclaration/css-style-declaration-named-setter.html

+++ b/LayoutTests/fast/dom/CSSStyleDeclaration/css-style-declaration-named-setter.html

@@ -16,6 +16,10 @@ shouldBeEqualToString("document.body.style.margin", "1px");

shouldBe("document.body.style.margin = 2", "2");

shouldBeEqualToString("document.body.style.margin", "2px");

+var badString = { toString: function() { throw "Exception in toString()"; } };

+shouldThrow("document.body.style.margin = badString", "'Exception in toString()'");

+shouldBeEqualToString("document.body.style.margin", "2px"); // Should not reset the previous value.

</script>

</body>

</html>