LayoutTests/http/tests/local/formdata/send-form-data-with-bad-string.html - Issue 74133005: Remove several uses of toWebCoreStringWithNullCheck(v8::Handle<v8::Value>)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/http/tests/local/formdata/send-form-data-with-bad-string.html

Issue 74133005: Remove several uses of toWebCoreStringWithNullCheck(v8::Handle<v8::Value>) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/xmlhttprequest/xmlhttprequest-open-exceptions-expected.txt ('k') | LayoutTests/http/tests/local/formdata/send-form-data-with-bad-string-expected.txt » ('j') | Source/bindings/v8/custom/V8FormDataCustom.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <body>

	4 <script src="../../../../resources/js-test.js"></script>

	5 <script>

	6 description("Test that passing bad strings to FormData.append() throws and abort s properly.");

	7

	8 var xhr = new XMLHttpRequest();

	9 xhr.open('POST', 'http://127.0.0.1:8000/xmlhttprequest/resources/post-echo.cgi', false);

	10 var badString = { toString: function() { throw "Exception in toString()"; } };

	11

	12 var formData = new FormData();

	13 shouldThrow("formData.append(badString, 'test')", "'Exception in toString()'");

	14 shouldThrow("formData.append('textarea', badString)", "'Exception in toString()' ");

	15 shouldThrow("formData.append('blob', new Blob(['']), badString)", "'Exception in toString()'");

	16

	17 xhr.send(formData);

	18 if (xhr.readyState !== 4 \|\| xhr.status !== 200) {

	19 testFailed('xhr.readyState = ' + xhr.readyState + ', xhr.status = ' + xhr.st atus);

	20 return;

	21 }

	22

	23 shouldBe("xhr.response.indexOf('test')", "-1");

	24 shouldBe("xhr.response.indexOf('textarea')", "-1");

	25 shouldBe("xhr.response.indexOf('blob')", "-1");

	26 </script>

	27 </body>

	28 </html>

OLD	NEW