Source/bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp - Issue 74133005: Remove several uses of toWebCoreStringWithNullCheck(v8::Handle<v8::Value>)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp

Issue 74133005: Remove several uses of toWebCoreStringWithNullCheck(v8::Handle<v8::Value>) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/local/formdata/send-form-data-with-bad-string-expected.txt ('k') | Source/bindings/v8/custom/V8FormDataCustom.cpp » ('j') | Source/bindings/v8/custom/V8FormDataCustom.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp

diff --git a/Source/bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp b/Source/bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp

index 545f375ec0417d57282902a2c895ee9a187ba9a8..cbf6a949ac08d3807b11f94c98963d85e6cd8286 100644

--- a/Source/bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp

+++ b/Source/bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp

@@ -230,8 +230,7 @@ void V8CSSStyleDeclaration::namedPropertySetterCustom(v8::Local<v8::String> name

if (!propInfo)

return;

- String propertyValue = toWebCoreStringWithNullCheck(value);

+ V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<WithNullCheck>, propertyValue, value);

ExceptionState exceptionState(info.Holder(), info.GetIsolate());

imp->setPropertyInternal(static_cast<CSSPropertyID>(propInfo->propID), propertyValue, false, exceptionState);