Remove several uses of toWebCoreStringWithNullCheck(v8::Handle<v8::Value>)

Source/bindings/v8/custom/V8FormDataCustom.cpp

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 29 matching lines @@
 namespace WebCore {
 
 void V8FormData::appendMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& info)
 {
     if (info.Length() < 2) {
         throwError(v8SyntaxError, "Not enough arguments", info.GetIsolate());
         return;
     }
 
     DOMFormData* domFormData = V8FormData::toNative(info.Holder());
-
-    String name = toWebCoreStringWithNullCheck(info[0]);
+    V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<WithNullCheck>, name, info[0]);
 
     v8::Handle<v8::Value> arg = info[1];
     if (V8Blob::hasInstance(arg, info.GetIsolate(), worldType(info.GetIsolate()))) {
         v8::Handle<v8::Object> object = v8::Handle<v8::Object>::Cast(arg);
         Blob* blob = V8Blob::toNative(object);
         ASSERT(blob);
 
         String filename;
-        if (info.Length() >= 3 && !info[2]->IsUndefined())
-            filename = toWebCoreStringWithNullCheck(info[2]);
+        if (info.Length() >= 3) {
+            V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<WithUndefinedOrNullCheck>, filenameResource, info[2]);

[haraken, 2013/11/15 22:20:15]

Not related to your CL, it looks inconsistent that we have an Undefined check
only for the third parameter. Is this behavior speced?

[Inactive, 2013/11/15 22:30:25]

Only the last argument is optional, doesn't it make sense that:
FormData.append(x, blob, undefined)
is equivalent to:
FormData.append(x, blob) ?

Here is the specification link:
http://xhr.spec.whatwg.org/#interface-formdata

[haraken, 2013/11/15 22:33:39]

Makes sense. Thanks for the clarification!

+            filename = filenameResource;
+        }
 
         domFormData->append(name, blob, filename);
-    } else
-        domFormData->append(name, toWebCoreStringWithNullCheck(arg));
+    } else {
+        V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<WithNullCheck>, argString, arg);
+        domFormData->append(name, argString);
+    }
 }
 
 } // namespace WebCore