LayoutTests/fast/xmlhttprequest/xmlhttprequest-open-exceptions.html - Issue 74133005: Remove several uses of toWebCoreStringWithNullCheck(v8::Handle<v8::Value>)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/xmlhttprequest/xmlhttprequest-open-exceptions.html

Issue 74133005: Remove several uses of toWebCoreStringWithNullCheck(v8::Handle<v8::Value>) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/frames/resources/frame-set-location-badstring.html ('k') | LayoutTests/fast/xmlhttprequest/xmlhttprequest-open-exceptions-expected.txt » ('j') | Source/bindings/v8/custom/V8FormDataCustom.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <meta http-equiv="Content-Security-Policy" content="connect-src http://examp le.com">	4 <meta http-equiv="Content-Security-Policy" content="connect-src http://examp le.com">

5 </head>	5 </head>

6 <body>	6 <body>

7 <script src="../../resources/js-test.js"></script>	7 <script src="../../resources/js-test.js"></script>

8 <script>	8 <script>

9 description("This tests that exceptions thrown by XHR.open() have reason able messages.");	9 description("This tests that exceptions thrown by XHR.open() have reason able messages.");

10	10

11 var xhrException;	11 var xhrException;

12 try {	12 try {

13 var xhr = new XMLHttpRequest();	13 var xhr = new XMLHttpRequest();

14 xhr.open("TRACE", "http://example.com/");	14 xhr.open("TRACE", "http://example.com/");

15 testFailed("xhr.open should throw an exception with a forbidden meth od type.");	15 testFailed("xhr.open should throw an exception with a forbidden meth od type.");

16 } catch (e) {	16 } catch (e) {

17 xhrException = e;	17 xhrException = e;

18 shouldBeEqualToString("xhrException.message", "Failed to execute 'op en' on 'XMLHttpRequest': 'TRACE' HTTP method is unsupported.");	18 shouldBeEqualToString("xhrException.message", "Failed to execute 'op en' on 'XMLHttpRequest': 'TRACE' HTTP method is unsupported.");

19 }	19 }

20	20

21 try {	21 try {

22 var xhr = new XMLHttpRequest();	22 var xhr = new XMLHttpRequest();

23 xhr.open("GET", "http://not.example.com/");	23 xhr.open("GET", "http://not.example.com/");

24 testFailed("xhr.open to a URL blocked by CSP should throw an excepti on.");	24 testFailed("xhr.open to a URL blocked by CSP should throw an excepti on.");

25 } catch (e) {	25 } catch (e) {

26 xhrException = e;	26 xhrException = e;

27 shouldBeEqualToString("xhrException.message", "Refused to connect to 'http://not.example.com/' because it violates the document's Content Security P olicy.");	27 shouldBeEqualToString("xhrException.message", "Refused to connect to 'http://not.example.com/' because it violates the document's Content Security P olicy.");

28 }	28 }

	29

	30 var badString = { toString: function() { throw "Exception in toString()" ; } };

	31 var xhr = new XMLHttpRequest();

	32 shouldBe("xhr.readyState", "XMLHttpRequest.UNSENT");

	33 shouldThrow("xhr.open('GET', 'resources/xmlhttprequest-get-data.xml', tr ue, badString, 'password');", "'Exception in toString()'");

	34 shouldBe("xhr.readyState", "XMLHttpRequest.UNSENT");

	35 shouldThrow("xhr.open('GET', 'resources/xmlhttprequest-get-data.xml', tr ue, 'username', badString);", "'Exception in toString()'");

	36 shouldBe("xhr.readyState", "XMLHttpRequest.UNSENT");

29 </script>	37 </script>

30 </body>	38 </body>

31 </html>	39 </html>

OLD	NEW