Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 722713002: DevTools: get rid of getters and setters in StatusBarButton. (Closed)

Created:
6 years, 1 month ago by pfeldman
Modified:
6 years, 1 month ago
Reviewers:
apavlov
CC:
blink-reviews, shans, apavlov+blink_chromium.org, rjwright, Steve Block, caseq+blink_chromium.org, aandrey+blink_chromium.org, pfeldman+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, dstockwell, Timothy Loh, devtools-reviews_chromium.org, Eric Willigers, loislo+blink_chromium.org, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, darktears, blink-reviews-animation_chromium.org, vsevik+blink_chromium.org, Mike Lawther (Google), sergeyv+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: get rid of getters and setters in StatusBarButton. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185285

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -157 lines) Patch
M LayoutTests/http/tests/inspector/search/source-frame-search.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/inspector/timeline-test.js View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/components/Drawer.js View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/devtools/front_end/components/InspectElementModeController.js View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/elements/AnimationsSidebarPane.js View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/main/AdvancedApp.js View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/devtools/front_end/network/NetworkPanel.js View 10 chunks +13 lines, -13 lines 0 comments Download
M Source/devtools/front_end/profiler/CPUProfileView.js View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/devtools/front_end/profiler/HeapSnapshotView.js View 4 chunks +10 lines, -10 lines 0 comments Download
M Source/devtools/front_end/profiler/ProfilesPanel.js View 4 chunks +6 lines, -6 lines 0 comments Download
M Source/devtools/front_end/promises/PromisePane.js View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/resources/ApplicationCacheItemsView.js View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/devtools/front_end/resources/CookieItemsView.js View 5 chunks +8 lines, -8 lines 0 comments Download
M Source/devtools/front_end/resources/DOMStorageItemsView.js View 7 chunks +7 lines, -7 lines 0 comments Download
M Source/devtools/front_end/resources/FileSystemView.js View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/sources/InplaceFormatterEditorAction.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/sources/ScriptFormatterEditorAction.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/sources/SourcesPanel.js View 7 chunks +11 lines, -11 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelinePanel.js View 6 chunks +12 lines, -12 lines 0 comments Download
M Source/devtools/front_end/timeline/TransformController.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/toolbox/ResponsiveDesignView.js View 4 chunks +7 lines, -7 lines 0 comments Download
M Source/devtools/front_end/ui/FilterBar.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/ui/SearchableView.js View 4 chunks +8 lines, -8 lines 0 comments Download
M Source/devtools/front_end/ui/SplitView.js View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/ui/StatusBarButton.js View 11 chunks +48 lines, -40 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
pfeldman
6 years, 1 month ago (2014-11-12 16:33:36 UTC) #2
apavlov
lgtm
6 years, 1 month ago (2014-11-13 10:56:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/722713002/20001
6 years, 1 month ago (2014-11-13 10:57:23 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-13 12:38:11 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 185285

Powered by Google App Engine
This is Rietveld 408576698