Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(988)

Unified Diff: Source/devtools/front_end/components/Drawer.js

Issue 722713002: DevTools: get rid of getters and setters in StatusBarButton. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/components/Drawer.js
diff --git a/Source/devtools/front_end/components/Drawer.js b/Source/devtools/front_end/components/Drawer.js
index 1c42dffa9c4f8f2e9458b61589fae41e6226f116..5698336597bb49cda85646e4e0cec23fee0f609e 100644
--- a/Source/devtools/front_end/components/Drawer.js
+++ b/Source/devtools/front_end/components/Drawer.js
@@ -114,14 +114,14 @@ WebInspector.Drawer.prototype = {
wasShown: function()
{
this.showView(this._lastSelectedViewSetting.get());
- this._toggleDrawerButton.toggled = true;
- this._toggleDrawerButton.title = WebInspector.UIString("Hide drawer.");
+ this._toggleDrawerButton.setToggled(true);
+ this._toggleDrawerButton.setTitle(WebInspector.UIString("Hide drawer."));
},
willHide: function()
{
- this._toggleDrawerButton.toggled = false;
- this._toggleDrawerButton.title = WebInspector.UIString("Show drawer.");
+ this._toggleDrawerButton.setToggled(false);
+ this._toggleDrawerButton.setTitle(WebInspector.UIString("Show drawer."));
},
/**
@@ -167,7 +167,7 @@ WebInspector.Drawer.prototype = {
toggle: function()
{
- if (this._toggleDrawerButton.toggled)
+ if (this._toggleDrawerButton.toggled())
this.closeDrawer();
else
this.showDrawer();
@@ -178,7 +178,7 @@ WebInspector.Drawer.prototype = {
*/
visible: function()
{
- return this._toggleDrawerButton.toggled;
+ return this._toggleDrawerButton.toggled();
},
/**

Powered by Google App Engine
This is Rietveld 408576698