Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(842)

Unified Diff: Source/devtools/front_end/timeline/TimelinePanel.js

Issue 722713002: DevTools: get rid of getters and setters in StatusBarButton. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/timeline/TimelinePanel.js
diff --git a/Source/devtools/front_end/timeline/TimelinePanel.js b/Source/devtools/front_end/timeline/TimelinePanel.js
index de243fa4f2387d826ce13df20225ab87f9548cd0..111479d506441a8be1c300521378e347cb2c9a6f 100644
--- a/Source/devtools/front_end/timeline/TimelinePanel.js
+++ b/Source/devtools/front_end/timeline/TimelinePanel.js
@@ -324,13 +324,13 @@ WebInspector.TimelinePanel.prototype = {
panelStatusBarElement.appendChild(garbageCollectButton.element);
var framesToggleButton = new WebInspector.StatusBarButton(WebInspector.UIString("Frames view. (Activity split into frames)"), "timeline-frames-status-bar-item");
- framesToggleButton.toggled = this._overviewModeSetting.get() === WebInspector.TimelinePanel.OverviewMode.Frames;
+ framesToggleButton.setToggled(this._overviewModeSetting.get() === WebInspector.TimelinePanel.OverviewMode.Frames);
framesToggleButton.addEventListener("click", this._overviewModeChanged.bind(this, framesToggleButton));
this._statusBarButtons.push(framesToggleButton);
panelStatusBarElement.appendChild(framesToggleButton.element);
this._flameChartToggleButton = new WebInspector.StatusBarButton(WebInspector.UIString("Flame chart view. (Use WASD or time selection to navigate)"), "timeline-flame-chart-status-bar-item");
- this._flameChartToggleButton.toggled = this._flameChartEnabledSetting.get();
+ this._flameChartToggleButton.setToggled(this._flameChartEnabledSetting.get());
this._flameChartToggleButton.addEventListener("click", this._flameChartEnabledChanged.bind(this));
this._statusBarButtons.push(this._flameChartToggleButton);
panelStatusBarElement.appendChild(this._flameChartToggleButton.element);
@@ -556,10 +556,10 @@ WebInspector.TimelinePanel.prototype = {
var oldMode = this._overviewModeSetting.get();
if (oldMode === WebInspector.TimelinePanel.OverviewMode.Events) {
this._overviewModeSetting.set(WebInspector.TimelinePanel.OverviewMode.Frames);
- button.toggled = true;
+ button.setToggled(true);
} else {
this._overviewModeSetting.set(WebInspector.TimelinePanel.OverviewMode.Events);
- button.toggled = false;
+ button.setToggled(false);
}
this._onModeChanged();
},
@@ -569,7 +569,7 @@ WebInspector.TimelinePanel.prototype = {
var oldValue = this._flameChartEnabledSetting.get();
var newValue = !oldValue;
this._flameChartEnabledSetting.set(newValue);
- this._flameChartToggleButton.toggled = newValue;
+ this._flameChartToggleButton.setToggled(newValue);
this._onModeChanged();
},
@@ -667,7 +667,7 @@ WebInspector.TimelinePanel.prototype = {
_onSuspendStateChanged: function()
{
- this._updateToggleTimelineButton(this.toggleTimelineButton.toggled);
+ this._updateToggleTimelineButton(this.toggleTimelineButton.toggled());
},
/**
@@ -675,18 +675,18 @@ WebInspector.TimelinePanel.prototype = {
*/
_updateToggleTimelineButton: function(toggled)
{
- this.toggleTimelineButton.toggled = toggled;
+ this.toggleTimelineButton.setToggled(toggled);
if (toggled) {
- this.toggleTimelineButton.title = WebInspector.UIString("Stop");
+ this.toggleTimelineButton.setTitle(WebInspector.UIString("Stop"));
this.toggleTimelineButton.setEnabled(true);
} else if (this._stopPending) {
- this.toggleTimelineButton.title = WebInspector.UIString("Stop pending");
+ this.toggleTimelineButton.setTitle(WebInspector.UIString("Stop pending"));
this.toggleTimelineButton.setEnabled(false);
} else if (WebInspector.targetManager.allTargetsSuspended()) {
- this.toggleTimelineButton.title = WebInspector.anotherProfilerActiveLabel();
+ this.toggleTimelineButton.setTitle(WebInspector.anotherProfilerActiveLabel());
this.toggleTimelineButton.setEnabled(false);
} else {
- this.toggleTimelineButton.title = WebInspector.UIString("Record");
+ this.toggleTimelineButton.setTitle(WebInspector.UIString("Record"));
this.toggleTimelineButton.setEnabled(true);
}
},
@@ -748,7 +748,7 @@ WebInspector.TimelinePanel.prototype = {
_recordingInProgress: function()
{
- return this.toggleTimelineButton.toggled;
+ return this.toggleTimelineButton.toggled();
},
/**
« no previous file with comments | « Source/devtools/front_end/sources/SourcesPanel.js ('k') | Source/devtools/front_end/timeline/TransformController.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698