Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1724)

Unified Diff: Source/devtools/front_end/profiler/ProfilesPanel.js

Issue 722713002: DevTools: get rid of getters and setters in StatusBarButton. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/profiler/ProfilesPanel.js
diff --git a/Source/devtools/front_end/profiler/ProfilesPanel.js b/Source/devtools/front_end/profiler/ProfilesPanel.js
index 7e941e101aad5f4b8850ab1a04bf6abaf10b6ac0..01d40dee977d0cb9758dacd8efa318616fb8f216 100644
--- a/Source/devtools/front_end/profiler/ProfilesPanel.js
+++ b/Source/devtools/front_end/profiler/ProfilesPanel.js
@@ -580,7 +580,7 @@ WebInspector.ProfilesPanel.prototype = {
_onSuspendStateChanged: function()
{
- this._updateRecordButton(this.recordButton.toggled);
+ this._updateRecordButton(this.recordButton.toggled());
},
/**
@@ -590,11 +590,11 @@ WebInspector.ProfilesPanel.prototype = {
{
var enable = toggled || !WebInspector.targetManager.allTargetsSuspended();
this.recordButton.setEnabled(enable);
- this.recordButton.toggled = toggled;
+ this.recordButton.setToggled(toggled);
if (enable)
- this.recordButton.title = this._selectedProfileType ? this._selectedProfileType.buttonTooltip : "";
+ this.recordButton.setTitle(this._selectedProfileType ? this._selectedProfileType.buttonTooltip : "");
else
- this.recordButton.title = WebInspector.anotherProfilerActiveLabel();
+ this.recordButton.setTitle(WebInspector.anotherProfilerActiveLabel());
if (this._selectedProfileType)
this._launcherView.updateProfileType(this._selectedProfileType, enable);
},
@@ -616,7 +616,7 @@ WebInspector.ProfilesPanel.prototype = {
_updateProfileTypeSpecificUI: function()
{
- this._updateRecordButton(this.recordButton.toggled);
+ this._updateRecordButton(this.recordButton.toggled());
this._profileTypeStatusBarItemsContainer.removeChildren();
var statusBarItems = this._selectedProfileType.statusBarItems;
if (statusBarItems) {
@@ -647,7 +647,7 @@ WebInspector.ProfilesPanel.prototype = {
this.removeAllListeners();
- this.recordButton.visible = true;
+ this.recordButton.setVisible(true);
this._profileViewStatusBarItemsContainer.classList.remove("hidden");
this.clearResultsButton.element.classList.remove("hidden");
this.profilesItemTreeElement.select();
« no previous file with comments | « Source/devtools/front_end/profiler/HeapSnapshotView.js ('k') | Source/devtools/front_end/promises/PromisePane.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698