Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Unified Diff: Source/devtools/front_end/profiler/HeapSnapshotView.js

Issue 722713002: DevTools: get rid of getters and setters in StatusBarButton. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/profiler/HeapSnapshotView.js
diff --git a/Source/devtools/front_end/profiler/HeapSnapshotView.js b/Source/devtools/front_end/profiler/HeapSnapshotView.js
index 3430523fd786f86a2c91d31903c10e99533a4c3f..f7465ef62059ffec154acd74fbfce0898f330fb2 100644
--- a/Source/devtools/front_end/profiler/HeapSnapshotView.js
+++ b/Source/devtools/front_end/profiler/HeapSnapshotView.js
@@ -144,15 +144,15 @@ WebInspector.HeapSnapshotView = function(dataDisplayDelegate, profile)
this._profile = profile;
this._baseSelect = new WebInspector.StatusBarComboBox(this._changeBase.bind(this));
- this._baseSelect.visible = false;
+ this._baseSelect.setVisible(false);
this._updateBaseOptions();
this._filterSelect = new WebInspector.StatusBarComboBox(this._changeFilter.bind(this));
- this._filterSelect.visible = false;
+ this._filterSelect.setVisible(false);
this._updateFilterOptions();
this._classNameFilter = new WebInspector.StatusBarInput("Class filter");
- this._classNameFilter.visible = false;
+ this._classNameFilter.setVisible(false);
this._constructorsDataGrid.setNameFilter(this._classNameFilter);
this._diffDataGrid.setNameFilter(this._classNameFilter);
@@ -188,9 +188,9 @@ WebInspector.HeapSnapshotView.Perspective.prototype = {
*/
deactivate: function(heapSnapshotView)
{
- heapSnapshotView._baseSelect.visible = false;
- heapSnapshotView._filterSelect.visible = false;
- heapSnapshotView._classNameFilter.visible = false;
+ heapSnapshotView._baseSelect.setVisible(false);
+ heapSnapshotView._filterSelect.setVisible(false);
+ heapSnapshotView._classNameFilter.setVisible(false);
if (heapSnapshotView._trackingOverviewGrid)
heapSnapshotView._trackingOverviewGrid.detach();
if (heapSnapshotView._allocationView)
@@ -247,8 +247,8 @@ WebInspector.HeapSnapshotView.SummaryPerspective.prototype = {
heapSnapshotView._constructorsView.show(heapSnapshotView._splitView.mainElement());
heapSnapshotView._objectDetailsView.show(heapSnapshotView._splitView.sidebarElement());
heapSnapshotView._splitView.show(heapSnapshotView._searchableView.element);
- heapSnapshotView._filterSelect.visible = true;
- heapSnapshotView._classNameFilter.visible = true;
+ heapSnapshotView._filterSelect.setVisible(true);
+ heapSnapshotView._classNameFilter.setVisible(true);
if (heapSnapshotView._trackingOverviewGrid) {
heapSnapshotView._trackingOverviewGrid.show(heapSnapshotView._searchableView.element, heapSnapshotView._splitView.element);
heapSnapshotView._trackingOverviewGrid.update();
@@ -297,8 +297,8 @@ WebInspector.HeapSnapshotView.ComparisonPerspective.prototype = {
heapSnapshotView._diffView.show(heapSnapshotView._splitView.mainElement());
heapSnapshotView._objectDetailsView.show(heapSnapshotView._splitView.sidebarElement());
heapSnapshotView._splitView.show(heapSnapshotView._searchableView.element);
- heapSnapshotView._baseSelect.visible = true;
- heapSnapshotView._classNameFilter.visible = true;
+ heapSnapshotView._baseSelect.setVisible(true);
+ heapSnapshotView._classNameFilter.setVisible(true);
},
/**
« no previous file with comments | « Source/devtools/front_end/profiler/CPUProfileView.js ('k') | Source/devtools/front_end/profiler/ProfilesPanel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698