Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1126)

Unified Diff: Source/devtools/front_end/ui/SearchableView.js

Issue 722713002: DevTools: get rid of getters and setters in StatusBarButton. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/ui/FilterBar.js ('k') | Source/devtools/front_end/ui/SplitView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/ui/SearchableView.js
diff --git a/Source/devtools/front_end/ui/SearchableView.js b/Source/devtools/front_end/ui/SearchableView.js
index 23072762896eacac59baba4e40dd39c758125fb3..90b51c29b9bbf54e134a17e3b94feac806604f8a 100644
--- a/Source/devtools/front_end/ui/SearchableView.js
+++ b/Source/devtools/front_end/ui/SearchableView.js
@@ -205,14 +205,14 @@ WebInspector.SearchableView.findPreviousShortcuts = function()
WebInspector.SearchableView.prototype = {
_toggleCaseSensitiveSearch: function()
{
- this._caseSensitiveButton.toggled = !this._caseSensitiveButton.toggled;
+ this._caseSensitiveButton.setToggled(!this._caseSensitiveButton.toggled());
this._saveSetting();
this._performSearch(false, true);
},
_toggleRegexSearch: function()
{
- this._regexButton.toggled = !this._regexButton.toggled;
+ this._regexButton.setToggled(!this._regexButton.toggled());
this._saveSetting();
this._performSearch(false, true);
},
@@ -235,8 +235,8 @@ WebInspector.SearchableView.prototype = {
if (!setting)
return;
var settingValue = setting.get() || {};
- settingValue.caseSensitive = this._caseSensitiveButton.toggled;
- settingValue.isRegex = this._regexButton.toggled;
+ settingValue.caseSensitive = this._caseSensitiveButton.toggled();
+ settingValue.isRegex = this._regexButton.toggled();
setting.set(settingValue);
},
@@ -244,9 +244,9 @@ WebInspector.SearchableView.prototype = {
{
var settingValue = this._setting() ? (this._setting().get() || {}) : {};
if (this._searchProvider.supportsCaseSensitiveSearch())
- this._caseSensitiveButton.toggled = !!settingValue.caseSensitive;
+ this._caseSensitiveButton.setToggled(!!settingValue.caseSensitive);
if (this._searchProvider.supportsRegexSearch())
- this._regexButton.toggled = !!settingValue.isRegex;
+ this._regexButton.setToggled(!!settingValue.isRegex);
},
/**
@@ -593,8 +593,8 @@ WebInspector.SearchableView.prototype = {
_currentSearchConfig: function()
{
var query = this._searchInputElement.value;
- var caseSensitive = this._caseSensitiveButton ? this._caseSensitiveButton.toggled : false;
- var isRegex = this._regexButton ? this._regexButton.toggled : false;
+ var caseSensitive = this._caseSensitiveButton ? this._caseSensitiveButton.toggled() : false;
+ var isRegex = this._regexButton ? this._regexButton.toggled() : false;
return new WebInspector.SearchableView.SearchConfig(query, caseSensitive, isRegex);
},
« no previous file with comments | « Source/devtools/front_end/ui/FilterBar.js ('k') | Source/devtools/front_end/ui/SplitView.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698