Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1181)

Unified Diff: Source/devtools/front_end/resources/DOMStorageItemsView.js

Issue 722713002: DevTools: get rid of getters and setters in StatusBarButton. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/resources/DOMStorageItemsView.js
diff --git a/Source/devtools/front_end/resources/DOMStorageItemsView.js b/Source/devtools/front_end/resources/DOMStorageItemsView.js
index 72e3e730a153a17e5ad36406c188e7185d265163..059c22bb79671b29b0f86b41cd09704897887d54 100644
--- a/Source/devtools/front_end/resources/DOMStorageItemsView.js
+++ b/Source/devtools/front_end/resources/DOMStorageItemsView.js
@@ -38,7 +38,7 @@ WebInspector.DOMStorageItemsView = function(domStorage)
this.element.classList.add("table");
this.deleteButton = new WebInspector.StatusBarButton(WebInspector.UIString("Delete"), "delete-storage-status-bar-item");
- this.deleteButton.visible = false;
+ this.deleteButton.setVisible(false);
this.deleteButton.addEventListener("click", this._deleteButtonClicked, this);
this.refreshButton = new WebInspector.StatusBarButton(WebInspector.UIString("Refresh"), "refresh-storage-status-bar-item");
@@ -63,7 +63,7 @@ WebInspector.DOMStorageItemsView.prototype = {
willHide: function()
{
- this.deleteButton.visible = false;
+ this.deleteButton.setVisible(false);
},
/**
@@ -76,7 +76,7 @@ WebInspector.DOMStorageItemsView.prototype = {
this._dataGrid.rootNode().removeChildren();
this._dataGrid.addCreationNode(false);
- this.deleteButton.visible = false;
+ this.deleteButton.setVisible(false);
event.consume(true);
},
@@ -98,7 +98,7 @@ WebInspector.DOMStorageItemsView.prototype = {
var childNode = children[i];
if (childNode.data.key === storageData.key) {
rootNode.removeChild(childNode);
- this.deleteButton.visible = (children.length > 1);
+ this.deleteButton.setVisible(children.length > 1);
return;
}
}
@@ -117,7 +117,7 @@ WebInspector.DOMStorageItemsView.prototype = {
var children = rootNode.children;
event.consume(true);
- this.deleteButton.visible = true;
+ this.deleteButton.setVisible(true);
for (var i = 0; i < children.length; ++i)
if (children[i].data.key === storageData.key)
@@ -156,7 +156,7 @@ WebInspector.DOMStorageItemsView.prototype = {
childNode.select();
childNode.reveal();
}
- this.deleteButton.visible = true;
+ this.deleteButton.setVisible(true);
}
}
},
@@ -174,7 +174,7 @@ WebInspector.DOMStorageItemsView.prototype = {
this._dataGrid = this._dataGridForDOMStorageItems(items);
this._dataGrid.show(this.element);
- this.deleteButton.visible = (this._dataGrid.rootNode().children.length > 1);
+ this.deleteButton.setVisible(this._dataGrid.rootNode().children.length > 1);
},
_dataGridForDOMStorageItems: function(items)
« no previous file with comments | « Source/devtools/front_end/resources/CookieItemsView.js ('k') | Source/devtools/front_end/resources/FileSystemView.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698