Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 709743002: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed)

Created:
6 years, 1 month ago by RAGHURAM
Modified:
6 years, 1 month ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/WebKit/Source/bindings This step is to move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/WebKit/Source/bindings (Ref: binding-methods changed: static v8::Handle<v8::Value> createDOMException(int, const String& sanitizedMessage, const String& unsanitizedMessage, const v8::Handle<v8::Object>& creationContext, v8::Isolate*) static v8::Handle<v8::Value> throwTypeError(const String&, v8::Isolate*)) BUG=424446 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184971

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -61 lines) Patch
M Source/bindings/core/v8/CustomElementConstructorBuilder.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/ExceptionState.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/ScriptPromise.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/V8ObjectConstructor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/V8ThrowException.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/core/v8/V8ThrowException.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/core/v8/custom/V8ElementCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/custom/V8HTMLDocumentCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/custom/V8InjectedScriptHostCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/custom/V8WebGLRenderingContextCustom.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/modules/v8/custom/V8SubtleCryptoCustom.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/templates/interface.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/templates/methods.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterface.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterface2.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceConstructor2.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceConstructor3.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceConstructor4.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceCustomConstructor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceEventConstructor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceEventTarget.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor2.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestObject.cpp View 12 chunks +14 lines, -14 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestTypedefs.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/modules/V8TestInterface5.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/testing/Internals.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
RAGHURAM
Please Review. Thanks & Regards
6 years, 1 month ago (2014-11-07 11:55:47 UTC) #2
haraken
LGTM
6 years, 1 month ago (2014-11-07 12:19:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/709743002/1
6 years, 1 month ago (2014-11-07 13:05:26 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-07 15:27:52 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184971

Powered by Google App Engine
This is Rietveld 408576698