Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Unified Diff: Source/bindings/core/v8/V8ThrowException.h

Issue 709743002: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/V8ObjectConstructor.cpp ('k') | Source/bindings/core/v8/V8ThrowException.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/V8ThrowException.h
diff --git a/Source/bindings/core/v8/V8ThrowException.h b/Source/bindings/core/v8/V8ThrowException.h
index 7d30a5d6df562774a15b96f6fbf3ef739f928e29..7f55aa6a26e0e79c9cb1555ccedf86ecadc7d56a 100644
--- a/Source/bindings/core/v8/V8ThrowException.h
+++ b/Source/bindings/core/v8/V8ThrowException.h
@@ -33,11 +33,11 @@ namespace blink {
class V8ThrowException {
public:
- static v8::Handle<v8::Value> createDOMException(int ec, const String& message, const v8::Handle<v8::Object>& creationContext, v8::Isolate* isolate)
+ static v8::Handle<v8::Value> createDOMException(v8::Isolate* isolate, int ec, const String& message, const v8::Handle<v8::Object>& creationContext)
{
- return createDOMException(ec, message, String(), creationContext, isolate);
+ return createDOMException(isolate, ec, message, String(), creationContext);
}
- static v8::Handle<v8::Value> createDOMException(int, const String& sanitizedMessage, const String& unsanitizedMessage, const v8::Handle<v8::Object>& creationContext, v8::Isolate*);
+ static v8::Handle<v8::Value> createDOMException(v8::Isolate*, int, const String& sanitizedMessage, const String& unsanitizedMessage, const v8::Handle<v8::Object>& creationContext);
static v8::Handle<v8::Value> throwDOMException(int ec, const String& message, const v8::Handle<v8::Object>& creationContext, v8::Isolate* isolate)
{
@@ -50,7 +50,7 @@ public:
static v8::Handle<v8::Value> createGeneralError(v8::Isolate*, const String&);
static v8::Handle<v8::Value> throwGeneralError(v8::Isolate*, const String&);
static v8::Handle<v8::Value> createTypeError(v8::Isolate*, const String&);
- static v8::Handle<v8::Value> throwTypeError(const String&, v8::Isolate*);
+ static v8::Handle<v8::Value> throwTypeError(v8::Isolate*, const String&);
static v8::Handle<v8::Value> createRangeError(v8::Isolate*, const String&);
static v8::Handle<v8::Value> throwRangeError(v8::Isolate*, const String&);
static v8::Handle<v8::Value> createSyntaxError(v8::Isolate*, const String&);
« no previous file with comments | « Source/bindings/core/v8/V8ObjectConstructor.cpp ('k') | Source/bindings/core/v8/V8ThrowException.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698