Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Unified Diff: Source/bindings/modules/v8/custom/V8SubtleCryptoCustom.cpp

Issue 709743002: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/modules/v8/custom/V8SubtleCryptoCustom.cpp
diff --git a/Source/bindings/modules/v8/custom/V8SubtleCryptoCustom.cpp b/Source/bindings/modules/v8/custom/V8SubtleCryptoCustom.cpp
index 990f8ee06091fa574495ae8bdb33f3fb7c61adb5..a12749ca1bc4e0fed6d2c866e880009b8367d751 100644
--- a/Source/bindings/modules/v8/custom/V8SubtleCryptoCustom.cpp
+++ b/Source/bindings/modules/v8/custom/V8SubtleCryptoCustom.cpp
@@ -23,7 +23,7 @@ void verify1Method(const v8::FunctionCallbackInfo<v8::Value>& info)
SubtleCrypto* impl = V8SubtleCrypto::toImpl(info.Holder());
TONATIVE_VOID(Dictionary, algorithm, Dictionary(info[0], info.GetIsolate()));
if (!algorithm.isUndefinedOrNull() && !algorithm.isObject()) {
- V8ThrowException::throwTypeError(ExceptionMessages::failedToExecute("verify", "SubtleCrypto", "parameter 1 ('algorithm') is not an object."), info.GetIsolate());
+ V8ThrowException::throwTypeError(info.GetIsolate(), ExceptionMessages::failedToExecute("verify", "SubtleCrypto", "parameter 1 ('algorithm') is not an object."));
return;
}
TONATIVE_VOID(CryptoKey*, key, V8CryptoKey::toImplWithTypeCheck(info.GetIsolate(), info[1]));
@@ -38,7 +38,7 @@ void verify2Method(const v8::FunctionCallbackInfo<v8::Value>& info)
SubtleCrypto* impl = V8SubtleCrypto::toImpl(info.Holder());
TONATIVE_VOID(Dictionary, algorithm, Dictionary(info[0], info.GetIsolate()));
if (!algorithm.isUndefinedOrNull() && !algorithm.isObject()) {
- V8ThrowException::throwTypeError(ExceptionMessages::failedToExecute("verify", "SubtleCrypto", "parameter 1 ('algorithm') is not an object."), info.GetIsolate());
+ V8ThrowException::throwTypeError(info.GetIsolate(), ExceptionMessages::failedToExecute("verify", "SubtleCrypto", "parameter 1 ('algorithm') is not an object."));
return;
}
TONATIVE_VOID(CryptoKey*, key, V8CryptoKey::toImplWithTypeCheck(info.GetIsolate(), info[1]));
@@ -53,7 +53,7 @@ void verify3Method(const v8::FunctionCallbackInfo<v8::Value>& info)
SubtleCrypto* impl = V8SubtleCrypto::toImpl(info.Holder());
TONATIVE_VOID(Dictionary, algorithm, Dictionary(info[0], info.GetIsolate()));
if (!algorithm.isUndefinedOrNull() && !algorithm.isObject()) {
- V8ThrowException::throwTypeError(ExceptionMessages::failedToExecute("verify", "SubtleCrypto", "parameter 1 ('algorithm') is not an object."), info.GetIsolate());
+ V8ThrowException::throwTypeError(info.GetIsolate(), ExceptionMessages::failedToExecute("verify", "SubtleCrypto", "parameter 1 ('algorithm') is not an object."));
return;
}
TONATIVE_VOID(CryptoKey*, key, V8CryptoKey::toImplWithTypeCheck(info.GetIsolate(), info[1]));
@@ -68,7 +68,7 @@ void verify4Method(const v8::FunctionCallbackInfo<v8::Value>& info)
SubtleCrypto* impl = V8SubtleCrypto::toImpl(info.Holder());
TONATIVE_VOID(Dictionary, algorithm, Dictionary(info[0], info.GetIsolate()));
if (!algorithm.isUndefinedOrNull() && !algorithm.isObject()) {
- V8ThrowException::throwTypeError(ExceptionMessages::failedToExecute("verify", "SubtleCrypto", "parameter 1 ('algorithm') is not an object."), info.GetIsolate());
+ V8ThrowException::throwTypeError(info.GetIsolate(), ExceptionMessages::failedToExecute("verify", "SubtleCrypto", "parameter 1 ('algorithm') is not an object."));
return;
}
TONATIVE_VOID(CryptoKey*, key, V8CryptoKey::toImplWithTypeCheck(info.GetIsolate(), info[1]));
« no previous file with comments | « Source/bindings/core/v8/custom/V8WebGLRenderingContextCustom.cpp ('k') | Source/bindings/templates/interface.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698