Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Side by Side Diff: Source/bindings/core/v8/V8ObjectConstructor.cpp

Issue 709743002: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/bindings/core/v8/ScriptPromise.cpp ('k') | Source/bindings/core/v8/V8ThrowException.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 v8::Local<v8::Object> V8ObjectConstructor::newInstanceInDocument(v8::Isolate* is olate, v8::Handle<v8::Function> function, int argc, v8::Handle<v8::Value> argv[] , Document* document) 52 v8::Local<v8::Object> V8ObjectConstructor::newInstanceInDocument(v8::Isolate* is olate, v8::Handle<v8::Function> function, int argc, v8::Handle<v8::Value> argv[] , Document* document)
53 { 53 {
54 if (function.IsEmpty()) 54 if (function.IsEmpty())
55 return v8::Local<v8::Object>(); 55 return v8::Local<v8::Object>();
56 return V8ScriptRunner::instantiateObjectInDocument(isolate, function, docume nt, argc, argv); 56 return V8ScriptRunner::instantiateObjectInDocument(isolate, function, docume nt, argc, argv);
57 } 57 }
58 58
59 void V8ObjectConstructor::isValidConstructorMode(const v8::FunctionCallbackInfo< v8::Value>& info) 59 void V8ObjectConstructor::isValidConstructorMode(const v8::FunctionCallbackInfo< v8::Value>& info)
60 { 60 {
61 if (ConstructorMode::current(info.GetIsolate()) == ConstructorMode::CreateNe wObject) { 61 if (ConstructorMode::current(info.GetIsolate()) == ConstructorMode::CreateNe wObject) {
62 V8ThrowException::throwTypeError("Illegal constructor", info.GetIsolate( )); 62 V8ThrowException::throwTypeError(info.GetIsolate(), "Illegal constructor ");
63 return; 63 return;
64 } 64 }
65 v8SetReturnValue(info, info.This()); 65 v8SetReturnValue(info, info.This());
66 } 66 }
67 67
68 } // namespace blink 68 } // namespace blink
OLDNEW
« no previous file with comments | « Source/bindings/core/v8/ScriptPromise.cpp ('k') | Source/bindings/core/v8/V8ThrowException.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698