Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.cpp - Issue 709743002: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.cpp

Issue 709743002: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor2.cpp ('k') | Source/bindings/tests/results/core/V8TestNode.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.cpp

diff --git a/Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.cpp b/Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.cpp

index d5f72ac9de09338555a415c5689688c266c8ea06..c56848bfe653cf470d655af7352621d9804ccffb 100644

--- a/Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.cpp

+++ b/Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.cpp

@@ -112,7 +112,7 @@ const WrapperTypeInfo V8TestInterfaceWillBeGarbageCollectedConstructor::wrapperT

static void V8TestInterfaceWillBeGarbageCollectedConstructorCallback(const v8::FunctionCallbackInfo<v8::Value>& info)

{

if (!info.IsConstructCall()) {

- V8ThrowException::throwTypeError(ExceptionMessages::constructorNotCallableAsFunction("TestInterface"), info.GetIsolate());

+ V8ThrowException::throwTypeError(info.GetIsolate(), ExceptionMessages::constructorNotCallableAsFunction("TestInterface"));

return;

}

@@ -156,7 +156,7 @@ void V8TestInterfaceWillBeGarbageCollected::constructorCallback(const v8::Functi

{

TRACE_EVENT_SCOPED_SAMPLING_STATE("blink", "DOMConstructor");

if (!info.IsConstructCall()) {

- V8ThrowException::throwTypeError(ExceptionMessages::constructorNotCallableAsFunction("TestInterfaceWillBeGarbageCollected"), info.GetIsolate());

+ V8ThrowException::throwTypeError(info.GetIsolate(), ExceptionMessages::constructorNotCallableAsFunction("TestInterfaceWillBeGarbageCollected"));

return;

}