Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Side by Side Diff: Source/bindings/core/v8/custom/V8ElementCustom.cpp

Issue 709743002: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 100 matching lines...) Expand 10 before | Expand all | Expand 10 after
111 v8SetReturnValueFast(info, WTF::getPtr(ElementAnimation::animate(*impl, effe ct, duration)), impl); 111 v8SetReturnValueFast(info, WTF::getPtr(ElementAnimation::animate(*impl, effe ct, duration)), impl);
112 } 112 }
113 113
114 // AnimationPlayer animate(AnimationEffect? effect, Dictionary timing); 114 // AnimationPlayer animate(AnimationEffect? effect, Dictionary timing);
115 void animate4Method(const v8::FunctionCallbackInfo<v8::Value>& info) 115 void animate4Method(const v8::FunctionCallbackInfo<v8::Value>& info)
116 { 116 {
117 Element* impl = V8Element::toImpl(info.Holder()); 117 Element* impl = V8Element::toImpl(info.Holder());
118 TONATIVE_VOID(AnimationEffect*, effect, V8AnimationEffect::toImplWithTypeChe ck(info.GetIsolate(), info[0])); 118 TONATIVE_VOID(AnimationEffect*, effect, V8AnimationEffect::toImplWithTypeChe ck(info.GetIsolate(), info[0]));
119 TONATIVE_VOID(Dictionary, timingInput, Dictionary(info[1], info.GetIsolate() )); 119 TONATIVE_VOID(Dictionary, timingInput, Dictionary(info[1], info.GetIsolate() ));
120 if (!timingInput.isUndefinedOrNull() && !timingInput.isObject()) { 120 if (!timingInput.isUndefinedOrNull() && !timingInput.isObject()) {
121 V8ThrowException::throwTypeError(ExceptionMessages::failedToExecute("ani mate", "Element", "parameter 2 ('timingInput') is not an object."), info.GetIsol ate()); 121 V8ThrowException::throwTypeError(info.GetIsolate(), ExceptionMessages::f ailedToExecute("animate", "Element", "parameter 2 ('timingInput') is not an obje ct."));
122 return; 122 return;
123 } 123 }
124 v8SetReturnValueFast(info, WTF::getPtr(ElementAnimation::animate(*impl, effe ct, timingInput)), impl); 124 v8SetReturnValueFast(info, WTF::getPtr(ElementAnimation::animate(*impl, effe ct, timingInput)), impl);
125 } 125 }
126 126
127 // [RaisesException] AnimationPlayer animate(sequence<Dictionary> effect, double timing); 127 // [RaisesException] AnimationPlayer animate(sequence<Dictionary> effect, double timing);
128 void animate5Method(const v8::FunctionCallbackInfo<v8::Value>& info) 128 void animate5Method(const v8::FunctionCallbackInfo<v8::Value>& info)
129 { 129 {
130 ExceptionState exceptionState(ExceptionState::ExecutionContext, "animate", " Element", info.Holder(), info.GetIsolate()); 130 ExceptionState exceptionState(ExceptionState::ExecutionContext, "animate", " Element", info.Holder(), info.GetIsolate());
131 Element* impl = V8Element::toImpl(info.Holder()); 131 Element* impl = V8Element::toImpl(info.Holder());
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
228 setArityTypeError(exceptionState, "[1]", info.Length()); 228 setArityTypeError(exceptionState, "[1]", info.Length());
229 exceptionState.throwIfNeeded(); 229 exceptionState.throwIfNeeded();
230 return; 230 return;
231 break; 231 break;
232 } 232 }
233 exceptionState.throwTypeError("No function was found that matched the signat ure provided."); 233 exceptionState.throwTypeError("No function was found that matched the signat ure provided.");
234 exceptionState.throwIfNeeded(); 234 exceptionState.throwIfNeeded();
235 } 235 }
236 236
237 } // namespace blink 237 } // namespace blink
OLDNEW
« no previous file with comments | « Source/bindings/core/v8/V8ThrowException.cpp ('k') | Source/bindings/core/v8/custom/V8HTMLDocumentCustom.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698