Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Side by Side Diff: Source/core/testing/Internals.cpp

Issue 709743002: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * Copyright (C) 2013 Apple Inc. All rights reserved. 3 * Copyright (C) 2013 Apple Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 8 *
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 281 matching lines...) Expand 10 before | Expand all | Expand 10 after
292 sprintf(buf, "%p", node); 292 sprintf(buf, "%p", node);
293 293
294 return String(buf); 294 return String(buf);
295 } 295 }
296 296
297 GCObservation* Internals::observeGC(ScriptValue scriptValue) 297 GCObservation* Internals::observeGC(ScriptValue scriptValue)
298 { 298 {
299 v8::Handle<v8::Value> observedValue = scriptValue.v8Value(); 299 v8::Handle<v8::Value> observedValue = scriptValue.v8Value();
300 ASSERT(!observedValue.IsEmpty()); 300 ASSERT(!observedValue.IsEmpty());
301 if (observedValue->IsNull() || observedValue->IsUndefined()) { 301 if (observedValue->IsNull() || observedValue->IsUndefined()) {
302 V8ThrowException::throwTypeError("value to observe is null or undefined" , v8::Isolate::GetCurrent()); 302 V8ThrowException::throwTypeError(v8::Isolate::GetCurrent(), "value to ob serve is null or undefined");
303 return nullptr; 303 return nullptr;
304 } 304 }
305 305
306 return GCObservation::create(observedValue); 306 return GCObservation::create(observedValue);
307 } 307 }
308 308
309 unsigned Internals::updateStyleAndReturnAffectedElementCount(ExceptionState& exc eptionState) const 309 unsigned Internals::updateStyleAndReturnAffectedElementCount(ExceptionState& exc eptionState) const
310 { 310 {
311 Document* document = contextDocument(); 311 Document* document = contextDocument();
312 if (!document) { 312 if (!document) {
(...skipping 1984 matching lines...) Expand 10 before | Expand all | Expand 10 after
2297 } 2297 }
2298 toHTMLPlugInElement(element)->setPlaceholder(DictionaryPluginPlaceholder::cr eate(element->document(), options)); 2298 toHTMLPlugInElement(element)->setPlaceholder(DictionaryPluginPlaceholder::cr eate(element->document(), options));
2299 } 2299 }
2300 2300
2301 Iterator* Internals::iterator(ScriptState* scriptState, ExceptionState& exceptio nState) 2301 Iterator* Internals::iterator(ScriptState* scriptState, ExceptionState& exceptio nState)
2302 { 2302 {
2303 return new InternalsIterator; 2303 return new InternalsIterator;
2304 } 2304 }
2305 2305
2306 } // namespace blink 2306 } // namespace blink
OLDNEW
« no previous file with comments | « Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698