[fsp] Pass more detailed errors to the providing extension.

[fsp] Pass more detailed errors to the providing extension.

Before, many methods were returning a simple bool, which was later converted
to a generic SECURITY error code (if false).

This patch converts such bools to base::File::Error, so we can convey the
specific error code.

Note, that base::File::Error is used to pass all error codes within the File
System API implementation, even if it's not really related to files. We may
want to introduce our own type in the future.

TEST=unit_tests, browser_tests: *FileSystemProvider*
BUG=248427
Committed: https://crrev.com/4c9bba032dd4eb99cec715caae9225a9c93dde00
Cr-Commit-Position: refs/heads/master@{#303413}

[mtomasz, 2014-11-06 10:15:32]

mtomasz@chromium.org changed reviewers:
+ fukino@chromium.org

[mtomasz, 2014-11-06 10:15:33]

@fukino: This is a pretty much mechanical change. PTAL. Thanks.

[mtomasz, 2014-11-07 00:18:03]

Patchset #2 (id:20001) has been deleted

[fukino, 2014-11-07 10:26:53]

Sorry for being late! lgtm with a small nit.

https://codereview.chromium.org/703123003/diff/1/chrome/browser/chromeos/file...
File chrome/browser/chromeos/file_system_provider/provided_file_system.cc
(right):

https://codereview.chromium.org/703123003/diff/1/chrome/browser/chromeos/file...
chrome/browser/chromeos/file_system_provider/provided_file_system.cc:625: //
methods so there is no rate.
nit: rate -> race?

[mtomasz, 2014-11-07 11:20:22]

https://codereview.chromium.org/703123003/diff/1/chrome/browser/chromeos/file...
File chrome/browser/chromeos/file_system_provider/provided_file_system.cc
(right):

https://codereview.chromium.org/703123003/diff/1/chrome/browser/chromeos/file...
chrome/browser/chromeos/file_system_provider/provided_file_system.cc:625: //
methods so there is no rate.
On 2014/11/07 10:26:53, fukino wrote:
> nit: rate -> race?

Done.

[mtomasz, 2014-11-07 11:20:27]

The CQ bit was checked by mtomasz@chromium.org

[commit-bot: I haz the power, 2014-11-07 11:20:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/703123003/40001

[commit-bot: I haz the power, 2014-11-07 12:32:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-07 12:32:32]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mtomasz, 2014-11-10 01:06:18]

The CQ bit was checked by mtomasz@chromium.org

[commit-bot: I haz the power, 2014-11-10 01:06:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/703123003/60001

[commit-bot: I haz the power, 2014-11-10 02:02:13]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2014-11-10 02:02:58]

Patchset 3 (id:??) landed as
https://crrev.com/4c9bba032dd4eb99cec715caae9225a9c93dde00
Cr-Commit-Position: refs/heads/master@{#303413}